Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(839)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: recipe_modules/step/example.expected/catch_timeout.json
Issue
2253943003
:
Formally define step config, pass to stream. (Closed)
Base URL: https://github.com/luci/recipes-py@nest-single-event
Patch Set: Rebase
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
recipe_engine/recipe_api.py
recipe_engine/run.py
recipe_engine/simulation_test.py
recipe_engine/step_runner.py
recipe_engine/stream.py
recipe_engine/types.py
recipe_engine/unittests/stream_test.py
recipe_engine/util.py
recipe_modules/platform/example.expected/linux64.json
recipe_modules/platform/example.expected/mac64.json
recipe_modules/platform/example.expected/win32.json
recipe_modules/step/api.py
recipe_modules/step/example.expected/basic.json
recipe_modules/step/example.expected/catch_timeout.json
recipe_modules/step/example.expected/defer_results.json
recipe_modules/step/example.expected/exceptional.json
recipe_modules/step/example.expected/infra_failure.json
recipe_modules/step/example.expected/invalid_access.json
recipe_modules/step/example.expected/timeout.json
recipe_modules/step/example.expected/warning.json
recipes.py
recipes/engine_tests/trigger.expected/basic.json
recipes/example/nested.expected/basic.json
View unified diff
|
Download patch
« recipe_modules/platform/example.expected/linux64.json
('K') |
« recipe_modules/step/example.expected/basic.json
('k') |
recipe_modules/step/example.expected/defer_results.json »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 [
1 [
2 {
2 {
3
"cmd": [
4
"sleep",
5
"20"
6
],
7
"name": "caught timeout",
8
"timeout": 1
9
},
10
{
3 "name": "$result",
11 "name": "$result",
4 "recipe_result": {
12 "recipe_result": {
5 "test_me": 4
13 "test_me": 4
6 },
14 },
7 "status_code": 0
15 "status_code": 0
8 }
16 }
9 ]
17 ]
OLD
NEW
« recipe_modules/platform/example.expected/linux64.json
('K') |
« recipe_modules/step/example.expected/basic.json
('k') |
recipe_modules/step/example.expected/defer_results.json »
('j') |
no next file with comments »
Issue 2253943003: Formally define step config, pass to stream. (Closed)
Created 4 years, 4 months ago by dnj
Modified 4 years, 3 months ago
Reviewers: martiniss, iannucci
Base URL: https://github.com/luci/recipes-py@nest-single-event
Comments: 21
This is Rietveld
408576698
Chromium Code Reviews
Issue 2253943003:
Formally define step config, pass to stream. (Closed)
Base URL: https://github.com/luci/recipes-py@nest-single-event