Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: build/common.gypi

Issue 225393007: Use -fuse-ld=gold when supported to select gold. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3817 matching lines...) Expand 10 before | Expand all | Expand 10 after
3828 # There seems to be a conflict of --icf and -pie 3828 # There seems to be a conflict of --icf and -pie
3829 # in gold which can generate crashy binaries. As 3829 # in gold which can generate crashy binaries. As
3830 # a security measure, -pie takes precendence for 3830 # a security measure, -pie takes precendence for
3831 # now. 3831 # now.
3832 #'-Wl,--icf=safe', 3832 #'-Wl,--icf=safe',
3833 '-Wl,--icf=none', 3833 '-Wl,--icf=none',
3834 ], 3834 ],
3835 }], 3835 }],
3836 ], 3836 ],
3837 }], 3837 }],
3838 # Newer gcc's support -fuse-ld, use the flag to force gold
3839 # selection.
3840 # gcc -- http://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Optimize-Opti ons.html
3841 # clang support -- http://clang-developers.42468.n3.nabble.com/Add ing-fuse-ld-support-to-clang-td4032180.html
Nico 2014/04/10 21:27:19 That link is just a thread where someone posted a
mithro-old 2014/04/11 02:17:56 Actually the patch did land and then was reverted.
3842 ['gcc_version>=48', {
3843 'cflags': [
3844 '-fuse-ld=gold',
3845 ],
3846 'ldflags': [
3847 '-fuse-ld=gold',
3848 ],
3849 }]
3838 ], 3850 ],
3839 }], 3851 }],
3840 ['linux_use_gold_binary==1', { 3852 ['linux_use_gold_binary==1', {
3841 'ldflags': [ 3853 'ldflags': [
3842 # Put our gold binary in the search path for the linker. 3854 # Put our gold binary in the search path for the linker.
3843 # We pass the path to gold to the compiler. gyp leaves 3855 # We pass the path to gold to the compiler. gyp leaves
3844 # unspecified what the cwd is when running the compiler, 3856 # unspecified what the cwd is when running the compiler,
3845 # so the normal gyp path-munging fails us. This hack 3857 # so the normal gyp path-munging fails us. This hack
3846 # gets the right path. 3858 # gets the right path.
3847 '-B<!(cd <(DEPTH) && pwd -P)/third_party/gold', 3859 '-B<!(cd <(DEPTH) && pwd -P)/third_party/gold',
(...skipping 1334 matching lines...) Expand 10 before | Expand all | Expand 10 after
5182 # settings in target dicts. SYMROOT is a special case, because many other 5194 # settings in target dicts. SYMROOT is a special case, because many other
5183 # Xcode variables depend on it, including variables such as 5195 # Xcode variables depend on it, including variables such as
5184 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5196 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5185 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5197 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5186 # files to appear (when present) in the UI as actual files and not red 5198 # files to appear (when present) in the UI as actual files and not red
5187 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5199 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5188 # and therefore SYMROOT, needs to be set at the project level. 5200 # and therefore SYMROOT, needs to be set at the project level.
5189 'SYMROOT': '<(DEPTH)/xcodebuild', 5201 'SYMROOT': '<(DEPTH)/xcodebuild',
5190 }, 5202 },
5191 } 5203 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698