Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: src/x64/assembler-x64.cc

Issue 225393005: x64: Make sure that the upper half of a 64bit register contains 0 for int32 values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased. Added comment. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/assembler-x64.h ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1371 matching lines...) Expand 10 before | Expand all | Expand 10 after
1382 src->link_to(pc_offset() - sizeof(int32_t)); 1382 src->link_to(pc_offset() - sizeof(int32_t));
1383 } else { 1383 } else {
1384 ASSERT(src->is_unused()); 1384 ASSERT(src->is_unused());
1385 int32_t current = pc_offset(); 1385 int32_t current = pc_offset();
1386 emitl(current); 1386 emitl(current);
1387 src->link_to(current); 1387 src->link_to(current);
1388 } 1388 }
1389 } 1389 }
1390 1390
1391 1391
1392 void Assembler::movsxbl(Register dst, const Operand& src) {
1393 EnsureSpace ensure_space(this);
1394 emit_optional_rex_32(dst, src);
1395 emit(0x0F);
1396 emit(0xBE);
1397 emit_operand(dst, src);
1398 }
1399
1400
1392 void Assembler::movsxbq(Register dst, const Operand& src) { 1401 void Assembler::movsxbq(Register dst, const Operand& src) {
1393 EnsureSpace ensure_space(this); 1402 EnsureSpace ensure_space(this);
1394 emit_rex_64(dst, src); 1403 emit_rex_64(dst, src);
1395 emit(0x0F); 1404 emit(0x0F);
1396 emit(0xBE); 1405 emit(0xBE);
1397 emit_operand(dst, src); 1406 emit_operand(dst, src);
1398 } 1407 }
1399 1408
1400 1409
1410 void Assembler::movsxwl(Register dst, const Operand& src) {
1411 EnsureSpace ensure_space(this);
1412 emit_optional_rex_32(dst, src);
1413 emit(0x0F);
1414 emit(0xBF);
1415 emit_operand(dst, src);
1416 }
1417
1418
1401 void Assembler::movsxwq(Register dst, const Operand& src) { 1419 void Assembler::movsxwq(Register dst, const Operand& src) {
1402 EnsureSpace ensure_space(this); 1420 EnsureSpace ensure_space(this);
1403 emit_rex_64(dst, src); 1421 emit_rex_64(dst, src);
1404 emit(0x0F); 1422 emit(0x0F);
1405 emit(0xBF); 1423 emit(0xBF);
1406 emit_operand(dst, src); 1424 emit_operand(dst, src);
1407 } 1425 }
1408 1426
1409 1427
1410 void Assembler::movsxlq(Register dst, Register src) { 1428 void Assembler::movsxlq(Register dst, Register src) {
(...skipping 1591 matching lines...) Expand 10 before | Expand all | Expand 10 after
3002 3020
3003 3021
3004 bool RelocInfo::IsInConstantPool() { 3022 bool RelocInfo::IsInConstantPool() {
3005 return false; 3023 return false;
3006 } 3024 }
3007 3025
3008 3026
3009 } } // namespace v8::internal 3027 } } // namespace v8::internal
3010 3028
3011 #endif // V8_TARGET_ARCH_X64 3029 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/assembler-x64.h ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698