Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 225393002: Apply OwnPtr|PassOwnPtr to m_validationMessageClient and setValidationMessageClient() in Page class (Closed)

Created:
6 years, 8 months ago by gyuyoung-inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Apply OwnPtr|PassOwnPtr to m_validationMessageClient and arguments of setValidationMessageClient() in Page class In WebViewImpl, m_validationMessage is only used for passing a pointer of ValidationMessageClient. To remove it, we need to apply OwnPtr|PassOwnPtr to m_validationMessageClient and an argument of setValidationMessageClient() in Page class. Additionally this cl makes to return a reference instead of a pointer of m_validationMessageClient in validationMessageClient() of Page class. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171004

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M Source/core/html/forms/ValidationMessage.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/page/Page.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/Page.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gyuyoung-inactive
Add jochen to reviewer.
6 years, 8 months ago (2014-04-04 19:07:53 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-07 13:01:01 UTC) #2
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-04-07 15:35:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/225393002/40001
6 years, 8 months ago (2014-04-07 15:35:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 16:35:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-07 16:35:11 UTC) #6
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 8 months ago (2014-04-07 23:00:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/225393002/40001
6 years, 8 months ago (2014-04-07 23:00:28 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 23:37:34 UTC) #9
Message was sent while issue was closed.
Change committed as 171004

Powered by Google App Engine
This is Rietveld 408576698