Chromium Code Reviews

Issue 2253923002: fix #27088, future then upwards inference (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
Leaf, scheglov, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+103 lines, -46 lines)
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +13 lines, -14 lines 0 comments
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +40 lines, -0 lines 0 comments
M pkg/analyzer/test/generated/analysis_context_factory.dart View 1 chunk +4 lines, -1 line 0 comments
M pkg/analyzer/test/src/task/strong/checker_test.dart View 11 chunks +28 lines, -28 lines 0 comments
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 3 chunks +18 lines, -2 lines 0 comments
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +0 lines, -1 line 0 comments

Messages

Total messages: 7 (2 generated)
Jennifer Messerly
4 years, 4 months ago (2016-08-17 15:39:51 UTC) #2
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-17 15:49:57 UTC) #3
Jennifer Messerly
Committed patchset #1 (id:1) manually as b3a38bd24513c7555d128ab644367862773ed217 (presubmit successful).
4 years, 4 months ago (2016-08-17 16:29:18 UTC) #5
scheglov
LGTM Thanks!
4 years, 4 months ago (2016-08-17 16:36:28 UTC) #6
Jennifer Messerly
4 years, 4 months ago (2016-08-17 16:40:18 UTC) #7
Message was sent while issue was closed.
On 2016/08/17 16:36:28, scheglov wrote:
> LGTM
> 
> Thanks!

No problem, thanks for catching that & narrowing it down!

Powered by Google App Engine