Move asm_module_ and asm_function_ down to DeclarationScope

Move asm_module_ and asm_function_ down to DeclarationScope

BUG=v8:5209
Committed: https://crrev.com/10c72887b555ce488cd7c64fd6324706db8b970a
Cr-Commit-Position: refs/heads/master@{#38753}

[Toon Verwaest, 2016-08-17 15:13:10]

verwaest@chromium.org changed reviewers:
+ titzer@chromium.org

[Toon Verwaest, 2016-08-17 15:13:10]

ptal

[bradnelson, 2016-08-17 21:44:52]

bradnelson@chromium.org changed reviewers:
+ adamk@chromium.org, bradnelson@chromium.org

[bradnelson, 2016-08-17 21:44:53]

Adam explained the general idea of what you're doing here (moving rarely used
fields to a less common structure).
Sounds good, but I defer to Ben + Adam for the review.

[Toon Verwaest, 2016-08-19 09:32:29]

ping

[titzer, 2016-08-19 09:38:55]

lgtm

https://codereview.chromium.org/2253913002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2253913002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1338: DCHECK(this->scope()->is_function_scope());
Is it possible that some yahoo would do "use asm" in a block scope?

[Toon Verwaest, 2016-08-19 11:04:45]

https://codereview.chromium.org/2253913002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2253913002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1338: DCHECK(this->scope()->is_function_scope());
On 2016/08/19 09:38:55, titzer wrote:
> Is it possible that some yahoo would do "use asm" in a block scope?

As far as I know directives are only processed at the top of functions.

[titzer, 2016-08-19 11:06:17]

On 2016/08/19 11:04:45, Toon Verwaest wrote:
> https://codereview.chromium.org/2253913002/diff/1/src/parsing/parser.cc
> File src/parsing/parser.cc (right):
> 
>
https://codereview.chromium.org/2253913002/diff/1/src/parsing/parser.cc#newco...
> src/parsing/parser.cc:1338: DCHECK(this->scope()->is_function_scope());
> On 2016/08/19 09:38:55, titzer wrote:
> > Is it possible that some yahoo would do "use asm" in a block scope?
> 
> As far as I know directives are only processed at the top of functions.

Can you write an mjsunit test?

[marja, 2016-08-19 12:42:19]

marja@chromium.org changed reviewers:
+ marja@chromium.org

[marja, 2016-08-19 12:42:20]

parser rubberstamp lgtm

(Not to be taken as a comment to the unit test discussion in either direction.)

[Toon Verwaest, 2016-08-19 12:45:00]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-08-19 12:45:01]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2253913002/#ps100001
(title: "fix test")

[commit-bot: I haz the power, 2016-08-19 12:45:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 13:29:20]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-19 13:29:42]

Description was changed from

==========
Move asm_module_ and asm_function_ down to DeclarationScope

BUG=v8:5209
==========

to

==========
Move asm_module_ and asm_function_ down to DeclarationScope

BUG=v8:5209

Committed: https://crrev.com/10c72887b555ce488cd7c64fd6324706db8b970a
Cr-Commit-Position: refs/heads/master@{#38753}
==========

[commit-bot: I haz the power, 2016-08-19 13:29:43]

Patchset 6 (id:??) landed as
https://crrev.com/10c72887b555ce488cd7c64fd6324706db8b970a
Cr-Commit-Position: refs/heads/master@{#38753}