Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2253873002: Fix the condition to allow format. (Closed)

Created:
4 years, 4 months ago by yamaguchi
Modified:
4 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the condition to allow format. When a drive is right-clicked, the focus of fileManager is not set to the drive unless it has been left-clicked once before that. test=manual test on device using a write-protected SD card and USB drive BUG=636373 Committed: https://crrev.com/cd72b4ad55b118790f0ed69847aa8f0a78e98004 Cr-Commit-Position: refs/heads/master@{#412731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
yamaguchi
4 years, 4 months ago (2016-08-17 12:16:30 UTC) #4
fukino
lgtm
4 years, 4 months ago (2016-08-17 14:15:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253873002/1
4 years, 4 months ago (2016-08-18 02:22:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 03:58:37 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 04:01:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd72b4ad55b118790f0ed69847aa8f0a78e98004
Cr-Commit-Position: refs/heads/master@{#412731}

Powered by Google App Engine
This is Rietveld 408576698