third_party/WebKit/Source/platform/SharedBuffer.h - Issue 2253853002: Remove SharedBuffer::unlock() and keep Resource's SharedBuffer always locked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/SharedBuffer.h

Issue 2253853002: Remove SharedBuffer::unlock() and keep Resource's SharedBuffer always locked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use hasClientsOrObservers() for live_size Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/PurgeableVectorTest.cpp ('k') | third_party/WebKit/Source/platform/SharedBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/SharedBuffer.h

diff --git a/third_party/WebKit/Source/platform/SharedBuffer.h b/third_party/WebKit/Source/platform/SharedBuffer.h

index a8d96c043df4899b9a3339bd1ca6851998a4a591..99671ebd6653b6e181ca2fb5302331526efb28ae 100644

--- a/third_party/WebKit/Source/platform/SharedBuffer.h

+++ b/third_party/WebKit/Source/platform/SharedBuffer.h

@@ -145,16 +145,6 @@ public:

// SkData without merging segmented buffers into a flat buffer.

sk_sp<SkData> getAsSkData() const;

- // See PurgeableVector::lock().

- bool lock();

- // WARNING: Calling unlock() on a SharedBuffer that wasn't created with the

- // purgeability option does an extra memcpy(). Please use

- // SharedBuffer::createPurgeable() if you intend to call unlock().

- void unlock();

- bool isLocked() const;

void onMemoryDump(const String& dumpPrefix, WebProcessMemoryDump*) const;

private:

« no previous file with comments | « third_party/WebKit/Source/platform/PurgeableVectorTest.cpp ('k') | third_party/WebKit/Source/platform/SharedBuffer.cpp » ('j') | no next file with comments »