third_party/WebKit/Source/core/fetch/FontResource.cpp - Issue 2253853002: Remove SharedBuffer::unlock() and keep Resource's SharedBuffer always locked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/FontResource.cpp

Issue 2253853002: Remove SharedBuffer::unlock() and keep Resource's SharedBuffer always locked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use hasClientsOrObservers() for live_size Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/fetch/FontResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/FontResource.cpp b/third_party/WebKit/Source/core/fetch/FontResource.cpp

index c0b615f73b8a3e6b02bb7dd802aeb09bc09f2c2f..df1c5cd29060d3605fd8188256b0b38720f4181d 100644

--- a/third_party/WebKit/Source/core/fetch/FontResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/FontResource.cpp

@@ -140,11 +140,6 @@ FontPlatformData FontResource::platformDataFromCustomData(float size, bool bold,

return m_fontData->fontPlatformData(size, bold, italic, orientation);

}

-bool FontResource::isSafeToUnlock() const

- return data()->hasOneRef();

void FontResource::fontLoadShortLimitCallback(TimerBase*)

{

if (!isLoading())

« no previous file with comments | « third_party/WebKit/Source/core/fetch/FontResource.h ('k') | third_party/WebKit/Source/core/fetch/ImageResource.h » ('j') | no next file with comments »