third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp - Issue 2253853002: Remove SharedBuffer::unlock() and keep Resource's SharedBuffer always locked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

Issue 2253853002: Remove SharedBuffer::unlock() and keep Resource's SharedBuffer always locked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use hasClientsOrObservers() for live_size Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h ('k') | third_party/WebKit/Source/core/fetch/FontResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

index 5df4c11ed2c7271481c98d59143bc8a547bbae10..763015bfe8f64e39a326e59f580e92bb117b0d73 100644

--- a/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

@@ -87,8 +87,6 @@ void CSSStyleSheetResource::didAddClient(ResourceClient* c)

const String CSSStyleSheetResource::sheetText(MIMETypeCheck mimeTypeCheck) const

{

- ASSERT(!isPurgeable());

if (!data() || data()->isEmpty() || !canUseSheet(mimeTypeCheck))

return String();

@@ -112,11 +110,6 @@ void CSSStyleSheetResource::checkNotify()

m_decodedSheetText = String();

}

-bool CSSStyleSheetResource::isSafeToUnlock() const

- return data()->hasOneRef();

void CSSStyleSheetResource::destroyDecodedDataIfPossible()

{

if (!m_parsedStyleSheetCache)