Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2253853002: Remove SharedBuffer::unlock() and keep Resource's SharedBuffer always locked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use hasClientsOrObservers() for live_size Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 bool canUseCacheValidator(); 214 bool canUseCacheValidator();
215 bool isCacheValidator() const { return m_isRevalidating; } 215 bool isCacheValidator() const { return m_isRevalidating; }
216 bool hasCacheControlNoStoreHeader() const; 216 bool hasCacheControlNoStoreHeader() const;
217 bool hasVaryHeader() const; 217 bool hasVaryHeader() const;
218 virtual bool mustRefetchDueToIntegrityMetadata(const FetchRequest& request) const { return false; } 218 virtual bool mustRefetchDueToIntegrityMetadata(const FetchRequest& request) const { return false; }
219 219
220 double currentAge() const; 220 double currentAge() const;
221 double freshnessLifetime(); 221 double freshnessLifetime();
222 double stalenessLifetime(); 222 double stalenessLifetime();
223 223
224 bool isPurgeable() const;
225 bool lock();
226
227 void setCacheIdentifier(const String& cacheIdentifier) { m_cacheIdentifier = cacheIdentifier; } 224 void setCacheIdentifier(const String& cacheIdentifier) { m_cacheIdentifier = cacheIdentifier; }
228 String cacheIdentifier() const { return m_cacheIdentifier; } 225 String cacheIdentifier() const { return m_cacheIdentifier; }
229 226
230 virtual void didSendData(unsigned long long /* bytesSent */, unsigned long l ong /* totalBytesToBeSent */) { } 227 virtual void didSendData(unsigned long long /* bytesSent */, unsigned long l ong /* totalBytesToBeSent */) { }
231 virtual void didDownloadData(int) { } 228 virtual void didDownloadData(int) { }
232 229
233 double loadFinishTime() const { return m_loadFinishTime; } 230 double loadFinishTime() const { return m_loadFinishTime; }
234 231
235 void addToEncodedBodyLength(int value) { m_response.addToEncodedBodyLength(v alue); } 232 void addToEncodedBodyLength(int value) { m_response.addToEncodedBodyLength(v alue); }
236 void addToDecodedBodyLength(int value) { m_response.addToDecodedBodyLength(v alue); } 233 void addToDecodedBodyLength(int value) { m_response.addToDecodedBodyLength(v alue); }
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 : m_request(request) 270 : m_request(request)
274 , m_redirectResponse(redirectResponse) 271 , m_redirectResponse(redirectResponse)
275 { 272 {
276 } 273 }
277 274
278 ResourceRequest m_request; 275 ResourceRequest m_request;
279 ResourceResponse m_redirectResponse; 276 ResourceResponse m_redirectResponse;
280 }; 277 };
281 const Vector<RedirectPair>& redirectChain() const { return m_redirectChain; } 278 const Vector<RedirectPair>& redirectChain() const { return m_redirectChain; }
282 279
283 virtual bool isSafeToUnlock() const { return false; }
284 virtual void destroyDecodedDataIfPossible() { } 280 virtual void destroyDecodedDataIfPossible() { }
285 281
286 virtual void markClientsAndObserversFinished(); 282 virtual void markClientsAndObserversFinished();
287 283
288 // Returns the memory dump name used for tracing. See Resource::onMemoryDump . 284 // Returns the memory dump name used for tracing. See Resource::onMemoryDump .
289 String getMemoryDumpName() const; 285 String getMemoryDumpName() const;
290 286
291 const HashCountedSet<ResourceClient*>& clients() const { return m_clients; } 287 const HashCountedSet<ResourceClient*>& clients() const { return m_clients; }
292 DataBufferingPolicy dataBufferingPolicy() const { return m_options.dataBuffe ringPolicy; } 288 DataBufferingPolicy dataBufferingPolicy() const { return m_options.dataBuffe ringPolicy; }
293 289
294 void setCachePolicyBypassingCache(); 290 void setCachePolicyBypassingCache();
295 void setLoFiStateOff(); 291 void setLoFiStateOff();
296 292
297 SharedBuffer* data() const { return m_data.get(); } 293 SharedBuffer* data() const { return m_data.get(); }
298 void clearData() { m_data.clear(); } 294 void clearData() { m_data.clear(); }
299 295
300 private: 296 private:
301 class ResourceCallback; 297 class ResourceCallback;
302 class CachedMetadataHandlerImpl; 298 class CachedMetadataHandlerImpl;
303 class ServiceWorkerResponseCachedMetadataHandler; 299 class ServiceWorkerResponseCachedMetadataHandler;
304 300
305 void cancelTimerFired(TimerBase*); 301 void cancelTimerFired(TimerBase*);
306 302
307 void revalidationSucceeded(const ResourceResponse&); 303 void revalidationSucceeded(const ResourceResponse&);
308 void revalidationFailed(); 304 void revalidationFailed();
309 305
310 size_t calculateOverheadSize() const; 306 size_t calculateOverheadSize() const;
311 307
312 bool unlock();
313
314 String reasonNotDeletable() const; 308 String reasonNotDeletable() const;
315 309
316 Member<CachedMetadataHandlerImpl> m_cacheHandler; 310 Member<CachedMetadataHandlerImpl> m_cacheHandler;
317 RefPtr<SecurityOrigin> m_fetcherSecurityOrigin; 311 RefPtr<SecurityOrigin> m_fetcherSecurityOrigin;
318 312
319 ResourceError m_error; 313 ResourceError m_error;
320 314
321 double m_loadFinishTime; 315 double m_loadFinishTime;
322 316
323 unsigned long m_identifier; 317 unsigned long m_identifier;
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 370
377 Resource::Type m_type; 371 Resource::Type m_type;
378 }; 372 };
379 373
380 #define DEFINE_RESOURCE_TYPE_CASTS(typeName) \ 374 #define DEFINE_RESOURCE_TYPE_CASTS(typeName) \
381 DEFINE_TYPE_CASTS(typeName##Resource, Resource, resource, resource->getType( ) == Resource::typeName, resource.getType() == Resource::typeName); 375 DEFINE_TYPE_CASTS(typeName##Resource, Resource, resource, resource->getType( ) == Resource::typeName, resource.getType() == Resource::typeName);
382 376
383 } // namespace blink 377 } // namespace blink
384 378
385 #endif 379 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/fetch/MemoryCache.cpp ('k') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698