Remove SharedBuffer::unlock() and keep Resource's SharedBuffer always locked

third_party/WebKit/Source/core/fetch/ImageResource.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
     Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 176 matching lines @@
     }
 
     ImageResourceObserverWalker walker(m_observers);
     while (const auto* observer = walker.next()) {
         priorityFromObserver(observer, priority);
     }
 
     return priority;
 }
 
-bool ImageResource::isSafeToUnlock() const
-{
-    // Note that |m_image| holds a reference to |data()| in addition to the one held by the Resource parent class.
-    return !m_image || (m_image->hasOneRef() && data()->refCount() == 2);
-}
-
 void ImageResource::destroyDecodedDataForFailedRevalidation()
 {
     clearImage();
     setDecodedSize(0);
 }
 
 void ImageResource::destroyDecodedDataIfPossible()
 {
     if (!m_image)
         return;
@@ skipping 55 matching lines @@
     return std::make_pair(brokenImageLoRes, 1);
 }
 
 bool ImageResource::willPaintBrokenImage() const
 {
     return errorOccurred();
 }
 
 blink::Image* ImageResource::getImage()
 {
-    ASSERT(!isPurgeable());
-
     if (errorOccurred()) {
         // Returning the 1x broken image is non-ideal, but we cannot reliably access the appropriate
         // deviceScaleFactor from here. It is critical that callers use ImageResource::brokenImage()
         // when they need the real, deviceScaleFactor-appropriate broken image icon.
         return brokenImage(1).first;
     }
 
     if (m_image)
         return m_image.get();
 
@@ skipping 11 matching lines @@
 bool ImageResource::imageHasRelativeSize() const
 {
     if (m_image)
         return m_image->hasRelativeSize();
 
     return false;
 }
 
 LayoutSize ImageResource::imageSize(RespectImageOrientationEnum shouldRespectImageOrientation, float multiplier, SizeType sizeType)
 {
-    ASSERT(!isPurgeable());
-
     if (!m_image)
         return LayoutSize();
 
     LayoutSize size;
 
     if (m_image->isBitmapImage() && shouldRespectImageOrientation == RespectImageOrientation)
         size = LayoutSize(toBitmapImage(m_image.get())->sizeRespectingOrientation());
     else
         size = LayoutSize(m_image->size());
 
@@ skipping 275 matching lines @@
     if (response().wasFetchedViaServiceWorker())
         return response().serviceWorkerResponseType() != WebServiceWorkerResponseTypeOpaque;
     if (!getImage()->currentFrameHasSingleSecurityOrigin())
         return false;
     if (passesAccessControlCheck(securityOrigin))
         return true;
     return !securityOrigin->taintsCanvas(response().url());
 }
 
 } // namespace blink