Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2253813002: Use ParentFrameTaskRunners for encodeImageOnEncoderThread (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 4 months ago
Reviewers:
kinuko, nhiroki, dcheng
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ParentFrameTaskRunners for encodeImageOnEncoderThread encodeImageOnEncoderThread should not use TaskRunnerHelper::get() because it posts a task from a worker thread to the main thread. Alternately, it should use ParentFrameTaskRunners. BUG=637974 Committed: https://crrev.com/03bcb665d7a873fd0694ec012da11d93a5ac4356 Cr-Commit-Position: refs/heads/master@{#412449}

Patch Set 1 #

Patch Set 2 : temp #

Messages

Total messages: 12 (7 generated)
haraken
PTAL Maybe we should move ParentFrameTaskRunners from core/workers/ to core/dom/ (where TaskRunnerHelper exists).
4 years, 4 months ago (2016-08-17 02:21:50 UTC) #2
kinuko
lgtm
4 years, 4 months ago (2016-08-17 03:39:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253813002/20001
4 years, 4 months ago (2016-08-17 04:19:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 04:23:17 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 04:25:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03bcb665d7a873fd0694ec012da11d93a5ac4356
Cr-Commit-Position: refs/heads/master@{#412449}

Powered by Google App Engine
This is Rietveld 408576698