Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2253803003: Ignore 7-bit encodings (Closed)

Created:
4 years, 4 months ago by Jinsuk Kim
Modified:
4 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore 7-bit encodings The only 7-bit encoding WHATWG standard supports is ISO-2022-JP. Ignore the othe 7-bit encoding detection results and return US-ASCII as the result. BUG=638001 Committed: https://crrev.com/92c0a07c47baac2ae7735338308ee2a5458c8b9c Cr-Commit-Position: refs/heads/master@{#412463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -5 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextEncodingDetector.cpp View 1 chunk +17 lines, -5 lines 0 comments Download
A third_party/WebKit/Source/platform/text/TextEncodingDetectorTest.cpp View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Jinsuk Kim
4 years, 4 months ago (2016-08-17 03:27:47 UTC) #2
tkent
Is the bug a regression by switching to CED?
4 years, 4 months ago (2016-08-17 03:36:26 UTC) #3
Jinsuk Kim
On 2016/08/17 03:36:26, tkent wrote: > Is the bug a regression by switching to CED? ...
4 years, 4 months ago (2016-08-17 04:08:15 UTC) #4
Jinsuk Kim
On 2016/08/17 04:08:15, Jinsuk wrote: > On 2016/08/17 03:36:26, tkent wrote: > > Is the ...
4 years, 4 months ago (2016-08-17 04:11:39 UTC) #5
tkent
lgtm
4 years, 4 months ago (2016-08-17 04:12:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253803003/1
4 years, 4 months ago (2016-08-17 04:14:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 06:45:54 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 06:47:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92c0a07c47baac2ae7735338308ee2a5458c8b9c
Cr-Commit-Position: refs/heads/master@{#412463}

Powered by Google App Engine
This is Rietveld 408576698