Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: net/base/net_util_unittest.cc

Issue 22538003: Add IP address handling to net::IsHostnameNonUnique (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disabled internal network check on Android Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_util.cc ('k') | net/cert/cert_verify_proc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_util_unittest.cc
diff --git a/net/base/net_util_unittest.cc b/net/base/net_util_unittest.cc
index 7c6bb572d77c363dc39d14560497966f16953702..22bcba16edc4cbce3c01fbf33436451b61c306f2 100644
--- a/net/base/net_util_unittest.cc
+++ b/net/base/net_util_unittest.cc
@@ -3517,15 +3517,27 @@ const NonUniqueNameTestData kNonUniqueNameTestData[] = {
// Domains under private registries.
{ true, "appspot.com" },
{ true, "test.appspot.com" },
- // IPv4 addresses (in various forms).
+ // Unreserved IPv4 addresses (in various forms).
{ true, "8.8.8.8" },
- { true, "1.2.3" },
- { true, "14.15" },
- { true, "676768" },
- // IPv6 addresses.
- { true, "FEDC:ba98:7654:3210:FEDC:BA98:7654:3210" },
- { true, "::192.9.5.5" },
- { true, "FEED::BEEF" },
+ { true, "99.64.0.0" },
+ { true, "212.15.0.0" },
+ { true, "212.15" },
+ { true, "212.15.0" },
+ { true, "3557752832" },
+ // Reserved IPv4 addresses (in various forms).
+ { false, "192.168.0.0" },
+ { false, "192.168.0.6" },
+ { false, "10.0.0.5" },
+ { false, "10.0" },
+ { false, "10.0.0" },
+ { false, "3232235526" },
+ // Unreserved IPv6 addresses.
+ { true, "FFC0:ba98:7654:3210:FEDC:BA98:7654:3210" },
+ { true, "2000:ba98:7654:2301:EFCD:BA98:7654:3210" },
+ // Reserved IPv6 addresses.
+ { false, "::192.9.5.5" },
+ { false, "FEED::BEEF" },
+ { false, "FEC0:ba98:7654:3210:FEDC:BA98:7654:3210" },
// 'internal'/non-IANA assigned domains.
{ false, "intranet" },
{ false, "intranet." },
« no previous file with comments | « net/base/net_util.cc ('k') | net/cert/cert_verify_proc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698