Add IP address handling to net::IsHostnameNonUnique

net/base/net_util_unittest.cc

Index: net/base/net_util_unittest.cc
diff --git a/net/base/net_util_unittest.cc b/net/base/net_util_unittest.cc
index 7c6bb572d77c363dc39d14560497966f16953702..249f5c90ce3a1da79241cba043aaf3bfc6fb0472 100644
--- a/net/base/net_util_unittest.cc
+++ b/net/base/net_util_unittest.cc
@@ -3519,13 +3519,17 @@ const NonUniqueNameTestData kNonUniqueNameTestData[] = {
     { true, "test.appspot.com" },
     // IPv4 addresses (in various forms).
     { true, "8.8.8.8" },
-    { true, "1.2.3" },
-    { true, "14.15" },
-    { true, "676768" },
+    { true, "99.64.0.0/10" },
+    { true, "212.15" },
+    { false, "192.168.0.0" },
+    { false, "192.168.0.6" },
+    //{ true, "676768" }, apparently this is valid & matches 0.0.0.0/8?

[Ryan Sleevi, 2013/08/07 19:04:44]

This was just me banging on the keyboard.

[felt, 2013/08/08 19:35:33]

ack

     // IPv6 addresses.
-    { true, "FEDC:ba98:7654:3210:FEDC:BA98:7654:3210" },
-    { true, "::192.9.5.5" },
-    { true, "FEED::BEEF" },
+    { true, "FFC0:ba98:7654:3210:FEDC:BA98:7654:3210" },
+    { true, "2000:ba98:7654:2301:EFCD:BA98:7654:3210" },
+    { false, "::192.9.5.5" },
+    { false, "FEED::BEEF" },
+    { false, "FEC0:ba98:7654:3210:FEDC:BA98:7654:3210" },
     // 'internal'/non-IANA assigned domains.
     { false, "intranet" },
     { false, "intranet." },
@@ -3550,6 +3554,7 @@ class NetUtilNonUniqueNameTest
 
  protected:
   bool IsUnique(const std::string& hostname) {
+    LOG(INFO) << hostname;
     return !IsHostnameNonUnique(hostname);
   }
 };