Add IP address handling to net::IsHostnameNonUnique

net/base/net_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/net_util.h"
 
 #include <string.h>
 
 #include <algorithm>
 
@@ skipping 3501 matching lines @@
 
 const NonUniqueNameTestData kNonUniqueNameTestData[] = {
     // Domains under ICANN-assigned domains.
     { true, "google.com" },
     { true, "google.co.uk" },
     // Domains under private registries.
     { true, "appspot.com" },
     { true, "test.appspot.com" },
     // IPv4 addresses (in various forms).
     { true, "8.8.8.8" },
-    { true, "1.2.3" },

[Ryan Sleevi, 2013/08/13 20:45:39]

Note: This was testing the two-dot form, but the replacement is fully qualified.
The comment on 3520 was trying to capture the "various forms" that an IP can be
represented, and they should all be parsed correctly.

If you want to test specifically for the reserved/non-reserved, feel free to add
additioanl IPs.

[felt, 2013/08/14 14:18:14]

restructured this so that it has all the same test cases in terms of formatting
but separated into reserved/unreserved

-    { true, "14.15" },
-    { true, "676768" },

[Ryan Sleevi, 2013/08/13 20:45:39]

Note: This was testing the dotless form (pure number) of an IPv4 address.

[felt, 2013/08/14 14:18:14]

Done.

+    { true, "99.64.0.0" },
+    { true, "212.15" },
+    { false, "192.168.0.0" },
+    { false, "192.168.0.6" },
+    { false, "10.0.0.5" },
     // IPv6 addresses.
-    { true, "FEDC:ba98:7654:3210:FEDC:BA98:7654:3210" },
-    { true, "::192.9.5.5" },
-    { true, "FEED::BEEF" },
+    { true, "FFC0:ba98:7654:3210:FEDC:BA98:7654:3210" },
+    { true, "2000:ba98:7654:2301:EFCD:BA98:7654:3210" },
+    { false, "::192.9.5.5" },
+    { false, "FEED::BEEF" },
+    { false, "FEC0:ba98:7654:3210:FEDC:BA98:7654:3210" },
     // 'internal'/non-IANA assigned domains.
     { false, "intranet" },
     { false, "intranet." },
     { false, "intranet.example" },
     { false, "host.intranet.example" },
     // gTLDs under discussion, but not yet assigned.
     { false, "intranet.corp" },
     { false, "example.tech" },
     { false, "intranet.internal" },
     // Invalid host names are treated as unique - but expected to be
@@ skipping 21 matching lines @@
 TEST_P(NetUtilNonUniqueNameTest, IsHostnameNonUnique) {
   const NonUniqueNameTestData& test_data = GetParam();
 
   EXPECT_EQ(test_data.is_unique, IsUnique(test_data.hostname));
 }
 
 INSTANTIATE_TEST_CASE_P(, NetUtilNonUniqueNameTest,
                         testing::ValuesIn(kNonUniqueNameTestData));
 
 }  // namespace net