core/fpdfapi/fpdf_parser/cpdf_reference.cpp - Issue 2253723002: Move parser pointer to CPDF_Document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_reference.cpp

Issue 2253723002: Move parser pointer to CPDF_Document (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Review feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_reference.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_reference.cpp b/core/fpdfapi/fpdf_parser/cpdf_reference.cpp

index 007423e5fb247c6d138a9ae3395fd3aebfb38011..92d0fa2b44e6334094e40df1437fc4295dde62b6 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_reference.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_reference.cpp

@@ -63,5 +63,6 @@ void CPDF_Reference::SetRef(CPDF_IndirectObjectHolder* pDoc, uint32_t objnum) {

}

CPDF_Object* CPDF_Reference::GetDirect() const {

- return m_pObjList ? m_pObjList->GetIndirectObject(m_RefObjNum) : nullptr;

+ return m_pObjList ? m_pObjList->GetIndirectObjectIfValid(m_RefObjNum)

+ : nullptr;

}