Move parser pointer to CPDF_Document

core/fpdfapi/fpdf_parser/cpdf_document.cpp

Index: core/fpdfapi/fpdf_parser/cpdf_document.cpp
diff --git a/core/fpdfapi/fpdf_parser/cpdf_document.cpp b/core/fpdfapi/fpdf_parser/cpdf_document.cpp
index bf1f93f887c6bf999efcba4926ee667ad659e60f..010078b350aae92604c7324a8b80b631d4bcb808 100644
--- a/core/fpdfapi/fpdf_parser/cpdf_document.cpp
+++ b/core/fpdfapi/fpdf_parser/cpdf_document.cpp
@@ -482,24 +482,45 @@ int CountPages(CPDF_Dictionary* pPages,
 }  // namespace
 
 CPDF_Document::CPDF_Document(CPDF_Parser* pParser)
-    : CPDF_IndirectObjectHolder(pParser),
+    : CPDF_IndirectObjectHolder(),
+      m_pParser(pParser),
       m_pRootDict(nullptr),
       m_pInfoDict(nullptr),
       m_bLinearized(false),
       m_iFirstPageNo(0),
       m_dwFirstPageObjNum(0),
       m_pDocPage(new CPDF_DocPageData(this)),
-      m_pDocRender(new CPDF_DocRenderData(this)) {}
+      m_pDocRender(new CPDF_DocRenderData(this)) {
+  if (pParser)
+    SetLastObjNum(m_pParser->GetLastObjNum());
+}
 
 CPDF_Document::~CPDF_Document() {
   delete m_pDocPage;
   CPDF_ModuleMgr::Get()->GetPageModule()->ClearStockFont(this);
 }
 
+CPDF_Object* CPDF_Document::GetIndirectObjectIfValid(uint32_t objnum) {

[Tom Sepez, 2016/08/17 16:46:44]

nit: maybe GetOrParseIndirectObject(), and de-virtualize.

[dsinclair, 2016/08/17 16:59:25]

Can't as this has to override the version from CPDF_IndirectObjectHolder so we
can do our parse magic. The name is terrible, but I can't come up with anything
better ....

+  CPDF_Object* pObj = GetIndirectObject(objnum);
+  if (pObj)
+    return pObj->GetObjNum() != CPDF_Object::kInvalidObjNum ? pObj : nullptr;
+
+  if (!m_pParser)
+    return nullptr;
+
+  pObj = m_pParser->ParseIndirectObject(this, objnum);
+  if (!pObj)
+    return nullptr;
+
+  pObj->m_ObjNum = objnum;
+  EmplaceIndirectObject(pObj);
+  return pObj;
+}
+
 void CPDF_Document::LoadDocInternal() {
-  m_LastObjNum = m_pParser->GetLastObjNum();
+  SetLastObjNum(m_pParser->GetLastObjNum());
 
-  CPDF_Object* pRootObj = GetIndirectObject(m_pParser->GetRootObjNum());
+  CPDF_Object* pRootObj = GetIndirectObjectIfValid(m_pParser->GetRootObjNum());
   if (!pRootObj)
     return;
 
@@ -507,7 +528,7 @@ void CPDF_Document::LoadDocInternal() {
   if (!m_pRootDict)
     return;
 
-  CPDF_Object* pInfoObj = GetIndirectObject(m_pParser->GetInfoObjNum());
+  CPDF_Object* pInfoObj = GetIndirectObjectIfValid(m_pParser->GetInfoObjNum());
   if (pInfoObj)
     m_pInfoDict = pInfoObj->GetDict();
   if (CPDF_Array* pIDArray = m_pParser->GetIDArray()) {
@@ -587,14 +608,14 @@ CPDF_Dictionary* CPDF_Document::GetPage(int iPage) {
 
   if (m_bLinearized && (iPage == m_iFirstPageNo)) {
     if (CPDF_Dictionary* pDict =
-            ToDictionary(GetIndirectObject(m_dwFirstPageObjNum))) {
+            ToDictionary(GetIndirectObjectIfValid(m_dwFirstPageObjNum))) {
       return pDict;
     }
   }
 
   int objnum = m_PageList.GetAt(iPage);
   if (objnum) {
-    if (CPDF_Dictionary* pDict = ToDictionary(GetIndirectObject(objnum)))
+    if (CPDF_Dictionary* pDict = ToDictionary(GetIndirectObjectIfValid(objnum)))
       return pDict;
   }
 
@@ -727,9 +748,8 @@ uint32_t CPDF_Document::GetUserPermissions() const {
 }
 
 FX_BOOL CPDF_Document::IsFormStream(uint32_t objnum, FX_BOOL& bForm) const {
-  auto it = m_IndirectObjs.find(objnum);
-  if (it != m_IndirectObjs.end()) {
-    CPDF_Stream* pStream = it->second->AsStream();
+  if (CPDF_Object* pObj = GetIndirectObject(objnum)) {
+    CPDF_Stream* pStream = pObj->AsStream();
     bForm = pStream && pStream->GetDict()->GetStringBy("Subtype") == "Form";
     return TRUE;
   }