Chromium Code Reviews| Index: core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h |
| diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h b/core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h |
| index c29746fdd79d8d4554713686fc00e69d0ed61a13..672258134b2d2ee7d964656e9d97cc9a10e44993 100644 |
| --- a/core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h |
| +++ b/core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h |
| @@ -19,10 +19,10 @@ class CPDF_IndirectObjectHolder { |
| using iterator = std::map<uint32_t, CPDF_Object*>::iterator; |
| using const_iterator = std::map<uint32_t, CPDF_Object*>::const_iterator; |
| - explicit CPDF_IndirectObjectHolder(CPDF_Parser* pParser); |
| - ~CPDF_IndirectObjectHolder(); |
| + CPDF_IndirectObjectHolder(); |
| + virtual ~CPDF_IndirectObjectHolder(); |
| - CPDF_Object* GetIndirectObject(uint32_t objnum); |
| + virtual CPDF_Object* GetIndirectObject(uint32_t objnum); |
| uint32_t AddIndirectObject(CPDF_Object* pObj); |
| void ReleaseIndirectObject(uint32_t objnum); |
| @@ -36,7 +36,6 @@ class CPDF_IndirectObjectHolder { |
| const_iterator end() const { return m_IndirectObjs.end(); } |
| protected: |
| - CPDF_Parser* m_pParser; |
| uint32_t m_LastObjNum; |
| std::map<uint32_t, CPDF_Object*> m_IndirectObjs; |
|
Tom Sepez
2016/08/16 22:22:34
and can this be a map to unique_ptrs as well? Yay
dsinclair
2016/08/17 15:57:46
ditto
|
| }; |