chrome/browser/ui/views/task_manager_view.h - Issue 2253683003: Turn TaskManagerView Context Menu Async

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/task_manager_view.h

Issue 2253683003: Turn TaskManagerView Context Menu Async (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/task_manager_view.h

diff --git a/chrome/browser/ui/views/task_manager_view.h b/chrome/browser/ui/views/task_manager_view.h

index 13bac52c08dd2379937a9fa06fc452e2cfd73a01..55e0311ce28e8223dda2aee7b0993754fbe25879 100644

--- a/chrome/browser/ui/views/task_manager_view.h

+++ b/chrome/browser/ui/views/task_manager_view.h

@@ -86,6 +86,7 @@ class TaskManagerView : public TableViewDelegate,

bool IsCommandIdChecked(int id) const override;

bool IsCommandIdEnabled(int id) const override;

void ExecuteCommand(int id, int event_flags) override;

+ void MenuClosed(ui::SimpleMenuModel* source) override;

private:

friend class TaskManagerViewTest;

@@ -111,6 +112,7 @@ class TaskManagerView : public TableViewDelegate,

std::unique_ptr<TaskManagerTableModel> table_model_;

+ std::unique_ptr<ui::SimpleMenuModel> menu_model_;

std::unique_ptr<views::MenuRunner> menu_runner_;

// We need to own the text of the menu, the Windows API does not copy it.