Turn TaskManagerView Context Menu Async

Turn TaskManagerView Context Menu Async

Convert the context menu of TaskManagerView to use the ASYNC menu runtype.

TEST=manual testing, ran TaskManagerViewTests
BUG=557136
Committed: https://crrev.com/4118eb427b371b5d25181064061d263ecf02698a
Cr-Commit-Position: refs/heads/master@{#412515}

[jonross, 2016-08-16 20:54:28]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 20:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 21:36:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 21:36:33]

Dry run: This issue passed the CQ dry run.

[jonross, 2016-08-16 22:17:10]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2016-08-16 22:17:11]

sky@ PTAL

[sky, 2016-08-16 22:33:06]

https://codereview.chromium.org/2253683003/diff/1/chrome/browser/ui/views/tas...
File chrome/browser/ui/views/task_manager_view.cc (right):

https://codereview.chromium.org/2253683003/diff/1/chrome/browser/ui/views/tas...
chrome/browser/ui/views/task_manager_view.cc:284: if (source !=
menu_model_.get())
Is this check necessary?

[jonross, 2016-08-16 23:01:49]

https://codereview.chromium.org/2253683003/diff/1/chrome/browser/ui/views/tas...
File chrome/browser/ui/views/task_manager_view.cc (right):

https://codereview.chromium.org/2253683003/diff/1/chrome/browser/ui/views/tas...
chrome/browser/ui/views/task_manager_view.cc:284: if (source !=
menu_model_.get())
On 2016/08/16 22:33:06, sky wrote:
> Is this check necessary?

It does not appear to be actually needed. You can't create a new context menu
without first shutting down the active one.

[sky, 2016-08-16 23:31:09]

LGTM

[jonross, 2016-08-17 13:22:17]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-08-17 13:22:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 14:04:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 14:05:51]

Description was changed from

==========
Turn TaskManagerView Context Menu Async

Convert the context menu of TaskManagerView to use the ASYNC menu runtype.

TEST=manual testing, ran TaskManagerViewTests
BUG=557136
==========

to

==========
Turn TaskManagerView Context Menu Async

Convert the context menu of TaskManagerView to use the ASYNC menu runtype.

TEST=manual testing, ran TaskManagerViewTests
BUG=557136

Committed: https://crrev.com/4118eb427b371b5d25181064061d263ecf02698a
Cr-Commit-Position: refs/heads/master@{#412515}
==========

[commit-bot: I haz the power, 2016-08-17 14:05:52]

Patchset 2 (id:??) landed as
https://crrev.com/4118eb427b371b5d25181064061d263ecf02698a
Cr-Commit-Position: refs/heads/master@{#412515}