third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h - Issue 2253643002: [DevTools] Copy objects from debugger context to inspected context properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

Issue 2253643002: [DevTools] Copy objects from debugger context to inspected context properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adapt Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/DebuggerContextAdapter.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

index 0bc55f155f6080365da378f398da872f02041e39..b87360cc9201972ad73cc754c83a9c5c526abc1b 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

@@ -76,7 +76,6 @@ public:

std::unique_ptr<V8StackTraceImpl> createStackTrace(v8::Local<v8::StackTrace>);

std::unique_ptr<V8StackTraceImpl> captureStackTrace(bool fullStack);

- v8::MaybeLocal<v8::Value> functionScopes(v8::Local<v8::Function>);

v8::MaybeLocal<v8::Array> internalProperties(v8::Local<v8::Context>, v8::Local<v8::Value>);

void asyncTaskScheduled(const String16& taskName, void* task, bool recurring);

@@ -102,8 +101,9 @@ private:

void handleV8AsyncTaskEvent(v8::Local<v8::Context>, v8::Local<v8::Object> executionState, v8::Local<v8::Object> eventData);

v8::Local<v8::Value> collectionEntries(v8::Local<v8::Context>, v8::Local<v8::Object>);

- v8::Local<v8::Value> generatorObjectLocation(v8::Local<v8::Object>);

+ v8::Local<v8::Value> generatorObjectLocation(v8::Local<v8::Context>, v8::Local<v8::Object>);

v8::Local<v8::Value> functionLocation(v8::Local<v8::Context>, v8::Local<v8::Function>);

+ v8::MaybeLocal<v8::Value> functionScopes(v8::Local<v8::Context>, v8::Local<v8::Function>);

v8::Isolate* m_isolate;

V8InspectorImpl* m_inspector;