[DevTools] Copy objects from debugger context to inspected context properly.

third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8Console.h"
 
 #include "platform/v8_inspector/InjectedScript.h"
 #include "platform/v8_inspector/InspectedContext.h"
 #include "platform/v8_inspector/V8Compat.h"
 #include "platform/v8_inspector/V8ConsoleMessage.h"
@@ skipping 641 matching lines @@
 }
 
 v8::Local<v8::Object> V8Console::createConsole(InspectedContext* inspectedContext, bool hasMemoryAttribute)
 {
     v8::Local<v8::Context> context = inspectedContext->context();
     v8::Context::Scope contextScope(context);
     v8::Isolate* isolate = context->GetIsolate();
     v8::MicrotasksScope microtasksScope(isolate, v8::MicrotasksScope::kDoNotRunMicrotasks);
 
     v8::Local<v8::Object> console = v8::Object::New(isolate);
+    bool success = console->SetPrototype(context, v8::Object::New(isolate)).FromMaybe(false);
+    DCHECK(success);
 
     createBoundFunctionProperty(context, console, "debug", V8Console::debugCallback);
     createBoundFunctionProperty(context, console, "error", V8Console::errorCallback);
     createBoundFunctionProperty(context, console, "info", V8Console::infoCallback);
     createBoundFunctionProperty(context, console, "log", V8Console::logCallback);
     createBoundFunctionProperty(context, console, "warn", V8Console::warnCallback);
     createBoundFunctionProperty(context, console, "dir", V8Console::dirCallback);
     createBoundFunctionProperty(context, console, "dirxml", V8Console::dirxmlCallback);
     createBoundFunctionProperty(context, console, "table", V8Console::tableCallback);
     createBoundFunctionProperty(context, console, "trace", V8Console::traceCallback);
     createBoundFunctionProperty(context, console, "group", V8Console::groupCallback);
     createBoundFunctionProperty(context, console, "groupCollapsed", V8Console::groupCollapsedCallback);
     createBoundFunctionProperty(context, console, "groupEnd", V8Console::groupEndCallback);
     createBoundFunctionProperty(context, console, "clear", V8Console::clearCallback);
     createBoundFunctionProperty(context, console, "count", V8Console::countCallback);
     createBoundFunctionProperty(context, console, "assert", V8Console::assertCallback);
     createBoundFunctionProperty(context, console, "markTimeline", V8Console::markTimelineCallback);
     createBoundFunctionProperty(context, console, "profile", V8Console::profileCallback);
     createBoundFunctionProperty(context, console, "profileEnd", V8Console::profileEndCallback);
     createBoundFunctionProperty(context, console, "timeline", V8Console::timelineCallback);
     createBoundFunctionProperty(context, console, "timelineEnd", V8Console::timelineEndCallback);
     createBoundFunctionProperty(context, console, "time", V8Console::timeCallback);
     createBoundFunctionProperty(context, console, "timeEnd", V8Console::timeEndCallback);
     createBoundFunctionProperty(context, console, "timeStamp", V8Console::timeStampCallback);
 
-    bool success = console->SetPrototype(context, v8::Object::New(isolate)).FromMaybe(false);
-    DCHECK(success);
-
     if (hasMemoryAttribute)
         console->SetAccessorProperty(toV8StringInternalized(isolate, "memory"), V8_FUNCTION_NEW_REMOVE_PROTOTYPE(context, V8Console::memoryGetterCallback, console, 0).ToLocalChecked(), V8_FUNCTION_NEW_REMOVE_PROTOTYPE(context, V8Console::memorySetterCallback, v8::Local<v8::Value>(), 0).ToLocalChecked(), static_cast<v8::PropertyAttribute>(v8::None), v8::DEFAULT);
 
     console->SetPrivate(context, inspectedContextPrivateKey(isolate), v8::External::New(isolate, inspectedContext));
     return console;
 }
 
 void V8Console::clearInspectedContextIfNeeded(v8::Local<v8::Context> context, v8::Local<v8::Object> console)
 {
     v8::Isolate* isolate = context->GetIsolate();
     console->SetPrivate(context, inspectedContextPrivateKey(isolate), v8::External::New(isolate, nullptr));
 }
 
 v8::Local<v8::Object> V8Console::createCommandLineAPI(InspectedContext* inspectedContext)
 {
     v8::Local<v8::Context> context = inspectedContext->context();
     v8::Isolate* isolate = context->GetIsolate();
     v8::MicrotasksScope microtasksScope(isolate, v8::MicrotasksScope::kDoNotRunMicrotasks);
 
     v8::Local<v8::Object> commandLineAPI = v8::Object::New(isolate);
+    bool success = commandLineAPI->SetPrototype(context, v8::Null(isolate)).FromMaybe(false);
+    DCHECK(success);
 
     createBoundFunctionProperty(context, commandLineAPI, "dir", V8Console::dirCallback, "function dir(value) { [Command Line API] }");
     createBoundFunctionProperty(context, commandLineAPI, "dirxml", V8Console::dirxmlCallback, "function dirxml(value) { [Command Line API] }");
     createBoundFunctionProperty(context, commandLineAPI, "profile", V8Console::profileCallback, "function profile(title) { [Command Line API] }");
     createBoundFunctionProperty(context, commandLineAPI, "profileEnd", V8Console::profileEndCallback, "function profileEnd(title) { [Command Line API] }");
     createBoundFunctionProperty(context, commandLineAPI, "clear", V8Console::clearCallback, "function clear() { [Command Line API] }");
     createBoundFunctionProperty(context, commandLineAPI, "table", V8Console::tableCallback, "function table(data, [columns]) { [Command Line API] }");
 
     createBoundFunctionProperty(context, commandLineAPI, "keys", V8Console::keysCallback, "function keys(object) { [Command Line API] }");
     createBoundFunctionProperty(context, commandLineAPI, "values", V8Console::valuesCallback, "function values(object) { [Command Line API] }");
@@ skipping 101 matching lines @@
             continue;
         if (name->IsString()) {
             v8::Local<v8::Value> descriptor;
             bool success = m_global->GetOwnPropertyDescriptor(m_context, v8::Local<v8::String>::Cast(name)).ToLocal(&descriptor);
             DCHECK(success);
         }
     }
 }
 
 } // namespace v8_inspector