Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2253613004: [wasm] Fix asm.js module instantiation on retry. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix asm.js module instantiation on retry. This fixes the case where a module is instantiated twice via the same closure when in the meantime another closure has destroyed and removed the WASM data attached to the SharedFunctionInfo. R=bradnelson@chromium.org TEST=mjsunit/asm/asm-validation BUG=v8:4203 Committed: https://crrev.com/f9763eb275e25654995b265f020f25d5d7634551 Cr-Commit-Position: refs/heads/master@{#38696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M src/runtime/runtime-compiler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/mjsunit/asm/asm-validation.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-17 18:11:31 UTC) #4
bradnelson
lgtm
4 years, 4 months ago (2016-08-17 18:16:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253613004/1
4 years, 4 months ago (2016-08-18 07:40:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 07:44:22 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 07:44:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9763eb275e25654995b265f020f25d5d7634551
Cr-Commit-Position: refs/heads/master@{#38696}

Powered by Google App Engine
This is Rietveld 408576698