Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2253613002: Adds the Material Text Accessibility library to the iOS build. (Closed)

Created:
4 years, 4 months ago by Olivier
Modified:
4 years, 4 months ago
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds the Material Text Accessibility library to the iOS build. BUG=623096 TEST=None Committed: https://crrev.com/68d75c23de08fa072fb88401ef6bca1d24141ca1 Cr-Commit-Position: refs/heads/master@{#412509}

Patch Set 1 #

Patch Set 2 : add LICENSE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, --1 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A ios/third_party/material_text_accessibility_ios/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
A + ios/third_party/material_text_accessibility_ios/LICENSE View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ios/third_party/material_text_accessibility_ios/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A ios/third_party/material_text_accessibility_ios/README.chromium View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Olivier
4 years, 4 months ago (2016-08-16 15:55:49 UTC) #2
rohitrao (ping after 24h)
LGTM to submit wednesday morning, unless I reply and say otherwise.
4 years, 4 months ago (2016-08-16 23:18:36 UTC) #3
Olivier
On 2016/08/16 23:18:36, rohitrao wrote: > LGTM to submit wednesday morning, unless I reply and ...
4 years, 4 months ago (2016-08-17 05:42:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253613002/1
4 years, 4 months ago (2016-08-17 11:10:44 UTC) #10
rohitrao (ping after 24h)
The android webview_licenses step is failing because it can't find the LICENSE file. This makes ...
4 years, 4 months ago (2016-08-17 11:20:31 UTC) #11
Olivier
Added license
4 years, 4 months ago (2016-08-17 11:58:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253613002/20001
4 years, 4 months ago (2016-08-17 11:59:59 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 12:53:10 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 12:55:05 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68d75c23de08fa072fb88401ef6bca1d24141ca1
Cr-Commit-Position: refs/heads/master@{#412509}

Powered by Google App Engine
This is Rietveld 408576698