Issue 22536006: chrome://inspect: Better support for multiple browsers and older versions of mobile Chrome

Issue 22536006: chrome://inspect: Better support for multiple browsers and older versions of mobile Chrome (Closed)

Created:
7 years, 4 months ago by Vladislav Kaznacheev

Modified:
7 years, 4 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, arv+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome://inspect: Better support for multiple browsers and older versions of mobile Chrome BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216993

Patch Set 2 : Rebased, addressed comments #

Patch Set 3 : Rebased, better version parsing #

Patch Set 4 : Rebase #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -63 lines)			Patch
M	chrome/browser/devtools/devtools_adb_bridge.h	View	1 2	2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/devtools/devtools_adb_bridge.cc	View	1 2	10 chunks	+38 lines, -30 lines	0 comments	Download
M	chrome/browser/resources/inspect/inspect.js	View	1 2	5 chunks	+57 lines, -25 lines	0 comments	Download
M	chrome/browser/ui/webui/inspect_ui.cc	View	1 2	2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/22536006/diff/1/chrome/browser/devtools/devtools_adb_bridge.cc File chrome/browser/devtools/devtools_adb_bridge.cc (right): https://codereview.chromium.org/22536006/diff/1/chrome/browser/devtools/devtools_adb_bridge.cc#newcode223 chrome/browser/devtools/devtools_adb_bridge.cc:223: browsers_.push_back(remote_browser); Why do you still need browsers_ given that ...

7 years, 4 months ago (2013-08-08 16:25:13 UTC) #2

Vladislav Kaznacheev

7 years, 4 months ago (2013-08-09 08:56:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/22536006/15001

7 years, 4 months ago (2013-08-12 11:51:53 UTC) #5

Message was sent while issue was closed.

Change committed as 216993

Expand Messages | Collapse Messages