Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2253543004: Move FamilyClass and Panose enums to enum class. (Closed)

Created:
4 years, 4 months ago by bungeman-skia
Modified:
4 years, 4 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move FamilyClass and Panose enums to enum class. The IBMFamilyClass and Panose structures are obvious candidates for simplification now that it is no longer necessary to nest enums inside structs to avoid name clashes. Committed: https://skia.googlesource.com/skia/+/4f81caf16995679adc05131823e209bf12844d3c

Patch Set 1 #

Patch Set 2 : Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+523 lines, -606 lines) Patch
M src/ports/SkTypeface_win_dw.cpp View 1 1 chunk +17 lines, -6 lines 0 comments Download
M src/sfnt/SkIBMFamilyClass.h View 2 chunks +92 lines, -112 lines 0 comments Download
M src/sfnt/SkPanose.h View 1 chunk +414 lines, -488 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
bungeman-skia
4 years, 4 months ago (2016-08-17 15:12:26 UTC) #12
hal.canary
lgtm
4 years, 4 months ago (2016-08-17 17:58:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253543004/20001
4 years, 4 months ago (2016-08-17 17:58:38 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 17:59:33 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4f81caf16995679adc05131823e209bf12844d3c

Powered by Google App Engine
This is Rietveld 408576698