Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2253543003: [wasm] Macro-ify checking of prototype flags. (Closed)

Created:
4 years, 4 months ago by titzer
Modified:
4 years, 4 months ago
Reviewers:
ahaas, John
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Macro-ify checking of prototype flags. R=ahaas@chromium.org BUG= Committed: https://crrev.com/b73376b908ef539e675e6557ac8d40899f3d1f1c Cr-Commit-Position: refs/heads/master@{#38658}

Patch Set 1 #

Patch Set 2 : [wasm] Macro-ify checking of prototype flags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -45 lines) Patch
M src/wasm/ast-decoder.cc View 8 chunks +14 lines, -38 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
titzer
4 years, 4 months ago (2016-08-16 11:01:27 UTC) #1
titzer
PTAL
4 years, 4 months ago (2016-08-16 12:34:52 UTC) #10
ahaas
lgtm
4 years, 4 months ago (2016-08-16 12:43:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253543003/20001
4 years, 4 months ago (2016-08-16 12:47:36 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 12:49:16 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 12:49:42 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b73376b908ef539e675e6557ac8d40899f3d1f1c
Cr-Commit-Position: refs/heads/master@{#38658}

Powered by Google App Engine
This is Rietveld 408576698