Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issue 2253513004: Fix off-by-one error in counter array sizing in BlimpStats. (Closed)

Created:
4 years, 4 months ago by Kevin M
Modified:
4 years, 4 months ago
Reviewers:
Wez, CJ
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix off-by-one error in counter array sizing in BlimpStats. BlimpStats' Atomic32[] array was missing an element thanks to the misapplication of a zero-indexed enum value. This lead to memory corruption when certain counter values were incremented. In this case, the zlib global flag "x86_cpu_enable_simd" was corrupted, leading zlib's deflate() function down invalid SSE SIMD codepaths. Also restored compression by reverting cl/2248943003. BUG=637376 R=lethalantidote@chromium.org,wez@chromium.org Committed: https://crrev.com/e4507bfea675457b628f51da133224f7b7f62ab3 Cr-Commit-Position: refs/heads/master@{#412380}

Patch Set 1 #

Patch Set 2 : spaces around plus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M blimp/net/blimp_stats.h View 1 1 chunk +1 line, -1 line 0 comments Download
M blimp/net/blimp_stats.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/net/stream_socket_connection.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Kevin M
4 years, 4 months ago (2016-08-16 22:51:36 UTC) #3
CJ
lgtm
4 years, 4 months ago (2016-08-16 22:54:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253513004/20001
4 years, 4 months ago (2016-08-16 22:58:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 23:47:38 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e4507bfea675457b628f51da133224f7b7f62ab3 Cr-Commit-Position: refs/heads/master@{#412380}
4 years, 4 months ago (2016-08-16 23:50:56 UTC) #9
Wez
4 years, 4 months ago (2016-08-19 00:57:04 UTC) #10
Message was sent while issue was closed.
Rubbery stampy LGTM

Powered by Google App Engine
This is Rietveld 408576698