Issue 2253503002: Remove virtual destructor from Variable, mark Variable final

Issue 2253503002: Remove virtual destructor from Variable, mark Variable final (Closed)

Created:
4 years, 4 months ago by Toon Verwaest

Modified:
4 years, 4 months ago

Reviewers:
vogelheim

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove virtual destructor from Variable, mark Variable final BUG= Committed: https://crrev.com/4872bc816fe53f4a2fd49783195e20f5ab71923f Cr-Commit-Position: refs/heads/master@{#38656}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	src/ast/variables.h	View		2 chunks	+1 line, -3 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253503002/1

4 years, 4 months ago (2016-08-16 12:03:24 UTC) #5

commit-bot: I haz the power

4 years, 4 months ago (2016-08-16 12:25:52 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4872bc816fe53f4a2fd49783195e20f5ab71923f
Cr-Commit-Position: refs/heads/master@{#38656}