openjpeg: Prevent an integer overflow in opj_jp2_apply_pclr.

openjpeg: Prevent an integer overflow in opj_jp2_apply_pclr.

This patch also prevent a null pointer access problem.

BUG=chromium:638829
R=ochang@chromium.org

[Oliver Chang, 2016-08-23 16:41:17]

Description was changed from

==========
openjpeg: Prevent an integer overflow in opj_jp2_apply_pclr.

This patch also prevent a null pointer access problem.

BUG=chromium:638829

R=ochang@chromium.org
==========

to

==========
openjpeg: Prevent an integer overflow in opj_jp2_apply_pclr.

This patch also prevent a null pointer access problem.

BUG=chromium:638829

R=ochang@chromium.org
==========

[Oliver Chang, 2016-08-23 16:41:17]

ochang@chromium.org changed reviewers:
+ thestig@chromium.org

[Oliver Chang, 2016-08-23 16:52:40]

Thanks for uploading a patch. I'm afraid I missed this for a few days -- you'll
need to click "Publish+Mail Comments" so that we get an email requesting the
review.

https://codereview.chromium.org/2253423002/diff/1/third_party/libopenjpeg20/j...
File third_party/libopenjpeg20/jp2.c (right):

https://codereview.chromium.org/2253423002/diff/1/third_party/libopenjpeg20/j...
third_party/libopenjpeg20/jp2.c:1028: for (j = 0; j < nr_channels; ++j) {
these lines are very similar to 995-1000. maybe consolidate them into another
function?

[Ke Liu, 2016-08-24 03:07:47]

On 2016/08/23 16:52:40, Oliver Chang (slow) wrote:
> Thanks for uploading a patch. I'm afraid I missed this for a few days --
you'll
> need to click "Publish+Mail Comments" so that we get an email requesting the
> review.
> 
>
https://codereview.chromium.org/2253423002/diff/1/third_party/libopenjpeg20/j...
> File third_party/libopenjpeg20/jp2.c (right):
> 
>
https://codereview.chromium.org/2253423002/diff/1/third_party/libopenjpeg20/j...
> third_party/libopenjpeg20/jp2.c:1028: for (j = 0; j < nr_channels; ++j) {
> these lines are very similar to 995-1000. maybe consolidate them into another
> function?

Hi Oliver, thanks for your reviewing. My old repository was deleted accidentally
so I uploaded another cl. Please review it at
https://codereview.chromium.org/2270343002/ . Please help me to close this cl.
Thanks.

[dsinclair, 2016-08-24 14:13:16]

On 2016/08/24 03:07:47, Ke Liu wrote:
> On 2016/08/23 16:52:40, Oliver Chang (slow) wrote:
> > Thanks for uploading a patch. I'm afraid I missed this for a few days --
> you'll
> > need to click "Publish+Mail Comments" so that we get an email requesting the
> > review.
> > 
> >
>
https://codereview.chromium.org/2253423002/diff/1/third_party/libopenjpeg20/j...
> > File third_party/libopenjpeg20/jp2.c (right):
> > 
> >
>
https://codereview.chromium.org/2253423002/diff/1/third_party/libopenjpeg20/j...
> > third_party/libopenjpeg20/jp2.c:1028: for (j = 0; j < nr_channels; ++j) {
> > these lines are very similar to 995-1000. maybe consolidate them into
another
> > function?
> 
> Hi Oliver, thanks for your reviewing. My old repository was deleted
accidentally
> so I uploaded another cl. Please review it at
> https://codereview.chromium.org/2270343002/ . Please help me to close this cl.
> Thanks.


In the future, you can create a branch locally and do 'git cl patch 2253423002'
to pull down the patch to your local branch. You can also do 'git cl issue
2253423002' to associate the given issue number to the current branch.