Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2253403002: Revert of Re-land "Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics." (Closed)

Created:
4 years, 4 months ago by dsansome
Modified:
4 years, 4 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, Paweł Hajdan Jr., ghost stip (do not use), agable
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Re-land "Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics." (patchset #1 id:1 of https://codereview.chromium.org/2257593003/ ) Reason for revert: Broke goma client master - crbug/638820 Original issue's description: > Re-land "Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics." > > We now have the right third_party dependencies in internal.DEPS too. > > BUG=620610 > TBR=sergeyberezin > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/3d927e12dbb73c4d7ee5503557fa3373258e5497 TBR=sergeyberezin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=620610 Committed: https://chromium.googlesource.com/chromium/tools/build/+/bcf2e37fb0b5fad5f9ce1d102d97f92a7f89bd5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -101 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M masters/buildbot.tac View 1 chunk +1 line, -24 lines 0 comments Download
M scripts/master/master_utils.py View 2 chunks +1 line, -3 lines 0 comments Download
D scripts/master/monitoring_status_receiver.py View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/baseweb.py View 3 chunks +2 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dsansome
Created Revert of Re-land "Make Buildbot masters send ts_mon metrics, and add standard HTTP server ...
4 years, 4 months ago (2016-08-18 06:06:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253403002/1
4 years, 4 months ago (2016-08-18 06:06:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/bcf2e37fb0b5fad5f9ce1d102d97f92a7f89bd5a
4 years, 4 months ago (2016-08-18 06:06:38 UTC) #5
Sergey Berezin
4 years, 4 months ago (2016-08-18 17:07:00 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698