chrome/installer/mini_installer/chrome.release - Issue 2253323002: Add a Canary-specific icon in VisualElementsManifest.xml

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mini_installer/chrome.release

Issue 2253323002: Add a Canary-specific icon in VisualElementsManifest.xml (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/mini_installer/chrome.release

diff --git a/chrome/installer/mini_installer/chrome.release b/chrome/installer/mini_installer/chrome.release

index cc0fcdf81142db04a26f858dc26ae3f7564db1da..aee906b3644ac68c05460cd15f67daf42ad01ed2 100644

--- a/chrome/installer/mini_installer/chrome.release

+++ b/chrome/installer/mini_installer/chrome.release

@@ -67,11 +67,12 @@ WidevineCdm\_platform_specific\win_x64\widevinecdmadapter.dll: %(VersionDir)s\Wi

PepperFlash\manifest.json: %(VersionDir)s\PepperFlash\

PepperFlash\pepflashplayer.dll: %(VersionDir)s\PepperFlash\

-# Win8 sub-dir.

+# VisualElements sub-dir.

grt (UTC plus 2) 2016/08/25 10:22:56 move this up above line 49 so that it's out of the

scottmg 2016/08/25 16:33:11 Ah, I see. Done.

-# All or none of the following 3 files need to be present as the creation of

+# All or none of the following files need to be present as the creation of

# VisualElementsManifest.xml is based on the existence of

-# %(VersionDir)\VisualElements. On a similar note, no other files should be

-# packaged in this directory.

+# %(VersionDir)\VisualElements.

Logo.png: %(VersionDir)s\VisualElements\

+LogoCanary.png: %(VersionDir)s\VisualElements\

SmallLogo.png: %(VersionDir)s\VisualElements\

+SmallLogoCanary.png: %(VersionDir)s\VisualElements\

« chrome/BUILD.gn ('K') | « chrome/app/visual_elements_resources/SmallLogo.png ('k') | chrome/installer/setup/install.cc » ('j') | chrome/installer/setup/install.cc » ('J')