Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2253313002: ui: Pass the correct container size to DelegatedFrameHostAndroid. (Closed)

Created:
4 years, 4 months ago by Khushal
Modified:
4 years, 4 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Pass the correct container size to DelegatedFrameHostAndroid. Currently we pass the VisibleViewportSize from RenderWidgetHostViewAndroid to the DelegatedFrameHostAndroid. ContentViewCore eliminates the size of the top controls from this size. So use GetViewportSizeDip instead. Also, the surface size for the SurfaceLayer is the size of the viewport itself, so it can directly be compared with the container size with no adjustments for the top controls. Committed: https://crrev.com/4c584d37669a3b2a4e0b80130cb61bad93b0e32e Cr-Commit-Position: refs/heads/master@{#413639}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/android/delegated_frame_host_android.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Khushal
4 years, 4 months ago (2016-08-17 23:02:50 UTC) #2
David Trainor- moved to gerrit
lgtm
4 years, 4 months ago (2016-08-18 16:42:30 UTC) #3
Khushal
On 2016/08/18 16:42:30, David Trainor wrote: > lgtm Thanks! ping to sievers@
4 years, 4 months ago (2016-08-18 17:49:04 UTC) #4
Khushal
On 2016/08/18 17:49:04, Khushal wrote: > On 2016/08/18 16:42:30, David Trainor wrote: > > lgtm ...
4 years, 4 months ago (2016-08-22 17:11:56 UTC) #5
no sievers
lgtm, thanks! https://codereview.chromium.org/2253313002/diff/1/ui/android/delegated_frame_host_android.cc File ui/android/delegated_frame_host_android.cc (right): https://codereview.chromium.org/2253313002/diff/1/ui/android/delegated_frame_host_android.cc#newcode113 ui/android/delegated_frame_host_android.cc:113: gfx::Size surface_size = root_pass->output_rect.size(); Ok, I didn't ...
4 years, 4 months ago (2016-08-22 21:47:46 UTC) #6
Khushal
https://codereview.chromium.org/2253313002/diff/1/ui/android/delegated_frame_host_android.cc File ui/android/delegated_frame_host_android.cc (right): https://codereview.chromium.org/2253313002/diff/1/ui/android/delegated_frame_host_android.cc#newcode113 ui/android/delegated_frame_host_android.cc:113: gfx::Size surface_size = root_pass->output_rect.size(); On 2016/08/22 21:47:46, sievers wrote: ...
4 years, 4 months ago (2016-08-22 21:52:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253313002/20001
4 years, 4 months ago (2016-08-23 01:39:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 02:33:46 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 02:35:15 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c584d37669a3b2a4e0b80130cb61bad93b0e32e
Cr-Commit-Position: refs/heads/master@{#413639}

Powered by Google App Engine
This is Rietveld 408576698