[turbofan] Unify Int32Add/Sub representation selection rules.

[turbofan] Unify Int32Add/Sub representation selection rules.

Unify the representation selection rules for NumberAdd/Subtract and
SpeculativeNumberAdd/Subtract wrt. Int32Add/Sub selection. We can
safely use Int32Add/Sub as long as the inputs are in the safe additive
integer range and the output is either truncated to Word32 or provably
in Signed32 or Unsigned32 range.

R=jarin@chromium.org

Committed: https://crrev.com/99edc1b8e72712af32b6a129763e1c88b155e325
Cr-Commit-Position: refs/heads/master@{#38746}

[Benedikt Meurer, 2016-08-19 07:11:53]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 07:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-08-19 07:13:04]

Hey Jaro,

Some refactoring to eventually unify the representation selection rules
somewhat.
Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2016-08-19 07:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 07:24:05]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Jarin, 2016-08-19 08:41:08]

lgtm once the tests are fixed.

https://codereview.chromium.org/2253293005/diff/1/src/compiler/simplified-low...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2253293005/diff/1/src/compiler/simplified-low...
src/compiler/simplified-lowering.cc:1132: VisitInt32Binop(node);
Use VisitWord32TuncatingBinop here, please.

(Eventually, we should get rid of VisitInt32Binop because it is misleading.)

[Benedikt Meurer, 2016-08-19 09:01:33]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 09:01:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-08-19 09:15:27]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 09:15:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-08-19 09:15:41]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-08-19 09:15:46]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-08-19 09:15:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2253293005/#ps40001
(title: "Address nit.")

[commit-bot: I haz the power, 2016-08-19 09:15:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-08-19 09:16:02]

Thanks, done.

https://codereview.chromium.org/2253293005/diff/1/src/compiler/simplified-low...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/2253293005/diff/1/src/compiler/simplified-low...
src/compiler/simplified-lowering.cc:1132: VisitInt32Binop(node);
On 2016/08/19 08:41:07, Jarin wrote:
> Use VisitWord32TuncatingBinop here, please.
> 
> (Eventually, we should get rid of VisitInt32Binop because it is misleading.)

Done.

[commit-bot: I haz the power, 2016-08-19 09:50:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-19 09:50:29]

Description was changed from

==========
[turbofan] Unify Int32Add/Sub representation selection rules.

Unify the representation selection rules for NumberAdd/Subtract and
SpeculativeNumberAdd/Subtract wrt. Int32Add/Sub selection. We can
safely use Int32Add/Sub as long as the inputs are in the safe additive
integer range and the output is either truncated to Word32 or provably
in Signed32 or Unsigned32 range.

R=jarin@chromium.org
==========

to

==========
[turbofan] Unify Int32Add/Sub representation selection rules.

Unify the representation selection rules for NumberAdd/Subtract and
SpeculativeNumberAdd/Subtract wrt. Int32Add/Sub selection. We can
safely use Int32Add/Sub as long as the inputs are in the safe additive
integer range and the output is either truncated to Word32 or provably
in Signed32 or Unsigned32 range.

R=jarin@chromium.org

Committed: https://crrev.com/99edc1b8e72712af32b6a129763e1c88b155e325
Cr-Commit-Position: refs/heads/master@{#38746}
==========

[commit-bot: I haz the power, 2016-08-19 09:50:30]

Patchset 3 (id:??) landed as
https://crrev.com/99edc1b8e72712af32b6a129763e1c88b155e325
Cr-Commit-Position: refs/heads/master@{#38746}