Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 4 months ago by Benedikt Meurer Modified:
4 years, 4 months ago Reviewers:
Jarin CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] Unify Int32Add/Sub representation selection rules.
Unify the representation selection rules for NumberAdd/Subtract and
SpeculativeNumberAdd/Subtract wrt. Int32Add/Sub selection. We can
safely use Int32Add/Sub as long as the inputs are in the safe additive
integer range and the output is either truncated to Word32 or provably
in Signed32 or Unsigned32 range.
R=jarin@chromium.org
Committed: https://crrev.com/99edc1b8e72712af32b6a129763e1c88b155e325
Cr-Commit-Position: refs/heads/master@{#38746}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Improve test case (also deal with Ignition better). #Patch Set 3 : Address nit. #
Created: 4 years, 4 months ago
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hey Jaro, Some refactoring to eventually unify the representation selection rules somewhat. Please take a look. Thanks, Benedikt
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
lgtm once the tests are fixed. https://codereview.chromium.org/2253293005/diff/1/src/compiler/simplified-low... File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/2253293005/diff/1/src/compiler/simplified-low... src/compiler/simplified-lowering.cc:1132: VisitInt32Binop(node); Use VisitWord32TuncatingBinop here, please. (Eventually, we should get rid of VisitInt32Binop because it is misleading.)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2253293005/#ps40001 (title: "Address nit.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks, done. https://codereview.chromium.org/2253293005/diff/1/src/compiler/simplified-low... File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/2253293005/diff/1/src/compiler/simplified-low... src/compiler/simplified-lowering.cc:1132: VisitInt32Binop(node); On 2016/08/19 08:41:07, Jarin wrote: > Use VisitWord32TuncatingBinop here, please. > > (Eventually, we should get rid of VisitInt32Binop because it is misleading.) Done.
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Unify Int32Add/Sub representation selection rules. Unify the representation selection rules for NumberAdd/Subtract and SpeculativeNumberAdd/Subtract wrt. Int32Add/Sub selection. We can safely use Int32Add/Sub as long as the inputs are in the safe additive integer range and the output is either truncated to Word32 or provably in Signed32 or Unsigned32 range. R=jarin@chromium.org ========== to ========== [turbofan] Unify Int32Add/Sub representation selection rules. Unify the representation selection rules for NumberAdd/Subtract and SpeculativeNumberAdd/Subtract wrt. Int32Add/Sub selection. We can safely use Int32Add/Sub as long as the inputs are in the safe additive integer range and the output is either truncated to Word32 or provably in Signed32 or Unsigned32 range. R=jarin@chromium.org Committed: https://crrev.com/99edc1b8e72712af32b6a129763e1c88b155e325 Cr-Commit-Position: refs/heads/master@{#38746} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/99edc1b8e72712af32b6a129763e1c88b155e325 Cr-Commit-Position: refs/heads/master@{#38746} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
