Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2253293003: Revert of Reduce window rectangles cap to 8 (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Reduce window rectangles cap to 8 (patchset #1 id:1 of https://codereview.chromium.org/2254013002/ ) Reason for revert: Breaking Ubuntu Original issue's description: > Reduce window rectangles cap to 8 > > Lowers the cap to 8 and adds a warning message if this value is ever > exceeded. The largest (only) implementation currently supports 8, so > there isn't yet reason to go higher. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2254013002 > > Committed: https://skia.googlesource.com/skia/+/52d721580ee22525c285e2d13cf3975a7a1b2843 TBR=mjk@nvidia.com,bsalomon@google.com,csmartdalton@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/36e5adbaaac9bfffa5eb377565e5c28659eb51af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/gpu/GrCaps.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrWindowRectangles.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
robertphillips
Created Revert of Reduce window rectangles cap to 8
4 years, 4 months ago (2016-08-17 23:29:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253293003/1
4 years, 4 months ago (2016-08-17 23:29:33 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 23:29:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/36e5adbaaac9bfffa5eb377565e5c28659eb51af

Powered by Google App Engine
This is Rietveld 408576698