SkPDF: in-place font subsetting

SkPDF: in-place font subsetting

Motivation: gross code simplification, also no bitset lookups at draw time.

SkPDFFont owns its glyph useage bitset.

SkPDFSubstituteMap goes away.

SkPDFObject interface is simplified.

SkPDFDocument tracks font usage (as hash set), not glyph usage.

SkPDFFont gets a simpler constructor.

SkPDFFont has first and last glyph set in constructor, not adjusted later.

SkPDFFont implementations are simplified.

SkPDFGlyphSet is replaced with simple SkBitSet.

SkPDFFont sizes its SkBitSets based on glyph count.

SkPDFGlyphSetMap goes away.

SkBitSet is now non-copyable.

SkBitSet now how utility methods to match old SkPDFGlyphSet.


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2253283004

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Release-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot

Committed: https://skia.googlesource.com/skia/+/530032a18e373ee673ae96fdbfa1fae6292f8f08

[hal.canary, 2016-08-18 18:59:49]

Description was changed from

==========
SkPDF: in-place font subsetting

Motivation: gross code simplification, also no bitset lookups at draw time.

SkPDFFont owns its glyph useage bitset.

SkPDFSubstituteMap goes away.

SkPDFObject interface is simplified.

SkPDFDocument tracks font usage (as hash set), not glyph usage.

SkPDFFont gets a simpler constructor.

SkPDFFont has first and last glyph set in constructor, not adjusted later.

SkPDFFont implementations are simplified.

SkPDFGlyphSet is replaced with simple SkBitSet.

SkPDFFont sizes its SkBitSets based on glyph count.

SkPDFGlyphSetMap goes away.

SkBitSet is now non-copyable.

SkBitSet now how utility methods to match old SkPDFGlyphSet.

BUG=skia:
==========

to

==========
SkPDF: in-place font subsetting

Motivation: gross code simplification, also no bitset lookups at draw time.

SkPDFFont owns its glyph useage bitset.

SkPDFSubstituteMap goes away.

SkPDFObject interface is simplified.

SkPDFDocument tracks font usage (as hash set), not glyph usage.

SkPDFFont gets a simpler constructor.

SkPDFFont has first and last glyph set in constructor, not adjusted later.

SkPDFFont implementations are simplified.

SkPDFGlyphSet is replaced with simple SkBitSet.

SkPDFFont sizes its SkBitSets based on glyph count.

SkPDFGlyphSetMap goes away.

SkBitSet is now non-copyable.

SkBitSet now how utility methods to match old SkPDFGlyphSet.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2253283004
==========

[hal.canary, 2016-08-18 18:59:59]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 19:00:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-08-18 19:01:43]

halcanary@google.com changed reviewers:
+ bungeman@google.com

[hal.canary, 2016-08-18 19:01:44]

PTAL.

20 files changed, 222 insertions(+), 506 deletions(-)

All PDF outputs are the same!

[hal.canary, 2016-08-18 19:02:11]

The CQ bit was unchecked by halcanary@google.com

[hal.canary, 2016-08-18 19:02:27]

Description was changed from

==========
SkPDF: in-place font subsetting

Motivation: gross code simplification, also no bitset lookups at draw time.

SkPDFFont owns its glyph useage bitset.

SkPDFSubstituteMap goes away.

SkPDFObject interface is simplified.

SkPDFDocument tracks font usage (as hash set), not glyph usage.

SkPDFFont gets a simpler constructor.

SkPDFFont has first and last glyph set in constructor, not adjusted later.

SkPDFFont implementations are simplified.

SkPDFGlyphSet is replaced with simple SkBitSet.

SkPDFFont sizes its SkBitSets based on glyph count.

SkPDFGlyphSetMap goes away.

SkBitSet is now non-copyable.

SkBitSet now how utility methods to match old SkPDFGlyphSet.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2253283004
==========

to

==========
SkPDF: in-place font subsetting

Motivation: gross code simplification, also no bitset lookups at draw time.

SkPDFFont owns its glyph useage bitset.

SkPDFSubstituteMap goes away.

SkPDFObject interface is simplified.

SkPDFDocument tracks font usage (as hash set), not glyph usage.

SkPDFFont gets a simpler constructor.

SkPDFFont has first and last glyph set in constructor, not adjusted later.

SkPDFFont implementations are simplified.

SkPDFGlyphSet is replaced with simple SkBitSet.

SkPDFFont sizes its SkBitSets based on glyph count.

SkPDFGlyphSetMap goes away.

SkBitSet is now non-copyable.

SkBitSet now how utility methods to match old SkPDFGlyphSet.


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2253283004

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Release-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot
==========

[hal.canary, 2016-08-18 19:03:02]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-08-18 19:03:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-08-18 19:03:14]

The CQ bit was unchecked by halcanary@google.com

[hal.canary, 2016-08-18 19:03:27]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 19:03:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-08-18 19:37:00]

https://codereview.chromium.org/2253283004/diff/1/src/pdf/SkPDFFont.cpp
File src/pdf/SkPDFFont.cpp (right):

https://codereview.chromium.org/2253283004/diff/1/src/pdf/SkPDFFont.cpp#newco...
src/pdf/SkPDFFont.cpp:54: void getFontSubset(SkPDFCanon*) override {} //
TODO(halcanary): implement
Is this any different from before?

https://codereview.chromium.org/2253283004/diff/1/src/pdf/SkPDFFont.cpp#newco...
src/pdf/SkPDFFont.cpp:596: // TODO(halcanary): subset this (advances and names).
This is logically the same TODO as the one added above (line 54)?

https://codereview.chromium.org/2253283004/diff/1/src/utils/SkBitSet.h
File src/utils/SkBitSet.h (right):

https://codereview.chromium.org/2253283004/diff/1/src/utils/SkBitSet.h#newcode50
src/utils/SkBitSet.h:50: }
nit: indentation for this block

[commit-bot: I haz the power, 2016-08-18 19:55:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 19:55:10]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-08-18 20:02:32]

https://codereview.chromium.org/2253283004/diff/1/src/pdf/SkPDFFont.cpp
File src/pdf/SkPDFFont.cpp (right):

https://codereview.chromium.org/2253283004/diff/1/src/pdf/SkPDFFont.cpp#newco...
src/pdf/SkPDFFont.cpp:54: void getFontSubset(SkPDFCanon*) override {} //
TODO(halcanary): implement
On 2016/08/18 19:37:00, bungeman-skia wrote:
> Is this any different from before?

nope.

https://codereview.chromium.org/2253283004/diff/1/src/pdf/SkPDFFont.cpp#newco...
src/pdf/SkPDFFont.cpp:596: // TODO(halcanary): subset this (advances and names).
On 2016/08/18 19:37:00, bungeman-skia wrote:
> This is logically the same TODO as the one added above (line 54)?

yes

https://codereview.chromium.org/2253283004/diff/1/src/utils/SkBitSet.h
File src/utils/SkBitSet.h (right):

https://codereview.chromium.org/2253283004/diff/1/src/utils/SkBitSet.h#newcode50
src/utils/SkBitSet.h:50: }
On 2016/08/18 19:37:00, bungeman-skia wrote:
> nit: indentation for this block

Done.

[hal.canary, 2016-08-18 20:02:41]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 20:02:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-08-18 20:48:18]

lgtm

[commit-bot: I haz the power, 2016-08-18 20:48:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:48:37]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-08-18 21:21:57]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-08-18 21:21:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 21:22:54]

Description was changed from

==========
SkPDF: in-place font subsetting

Motivation: gross code simplification, also no bitset lookups at draw time.

SkPDFFont owns its glyph useage bitset.

SkPDFSubstituteMap goes away.

SkPDFObject interface is simplified.

SkPDFDocument tracks font usage (as hash set), not glyph usage.

SkPDFFont gets a simpler constructor.

SkPDFFont has first and last glyph set in constructor, not adjusted later.

SkPDFFont implementations are simplified.

SkPDFGlyphSet is replaced with simple SkBitSet.

SkPDFFont sizes its SkBitSets based on glyph count.

SkPDFGlyphSetMap goes away.

SkBitSet is now non-copyable.

SkBitSet now how utility methods to match old SkPDFGlyphSet.


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2253283004

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Release-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot
==========

to

==========
SkPDF: in-place font subsetting

Motivation: gross code simplification, also no bitset lookups at draw time.

SkPDFFont owns its glyph useage bitset.

SkPDFSubstituteMap goes away.

SkPDFObject interface is simplified.

SkPDFDocument tracks font usage (as hash set), not glyph usage.

SkPDFFont gets a simpler constructor.

SkPDFFont has first and last glyph set in constructor, not adjusted later.

SkPDFFont implementations are simplified.

SkPDFGlyphSet is replaced with simple SkBitSet.

SkPDFFont sizes its SkBitSets based on glyph count.

SkPDFGlyphSetMap goes away.

SkBitSet is now non-copyable.

SkBitSet now how utility methods to match old SkPDFGlyphSet.


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2253283004

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Release-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot

Committed:
https://skia.googlesource.com/skia/+/530032a18e373ee673ae96fdbfa1fae6292f8f08
==========

[commit-bot: I haz the power, 2016-08-18 21:22:55]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/530032a18e373ee673ae96fdbfa1fae6292f8f08