chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa_unittest.mm - Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa_unittest.mm

Issue 2253233005: Change ScopedVector to vector<unique_ptr> in the password's UI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm ('K') | « chrome/browser/ui/cocoa/passwords/passwords_bubble_browsertest.mm ('k') | chrome/browser/ui/cocoa/passwords/passwords_list_view_controller.h » ('j') | chrome/browser/ui/passwords/manage_passwords_state.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa_unittest.mm

diff --git a/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa_unittest.mm b/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa_unittest.mm

index af7d02779612527f1fde9fc5ad723dd6bbd4ae48..46d46a7c6b3754017f11cadddc0d355f761c8599 100644

--- a/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa_unittest.mm

+++ b/chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa_unittest.mm

@@ -68,7 +68,7 @@ class ManagePasswordsBubbleCocoaTest : public CocoaProfileTest {

ASSERT_TRUE(testing::Mock::VerifyAndClearExpectations(mock));

autofill::PasswordForm form;

EXPECT_CALL(*mock, GetPendingPassword()).WillOnce(ReturnRef(form));

- std::vector<const autofill::PasswordForm*> forms;

+ std::vector<std::unique_ptr<autofill::PasswordForm>> forms;

EXPECT_CALL(*mock, GetCurrentForms()).WillOnce(ReturnRef(forms));

GURL origin;

EXPECT_CALL(*mock, GetOrigin()).WillOnce(ReturnRef(origin));