Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: remoting/client/gl_renderer_unittest.cc

Issue 2253233004: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/client/gl_desktop.cc ('k') | remoting/client/jni/chromoting_jni_instance.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/client/gl_renderer.h" 5 #include "remoting/client/gl_renderer.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 renderer_.reset(new GlRenderer()); 108 renderer_.reset(new GlRenderer());
109 renderer_->SetDelegate(delegate_.GetWeakPtr()); 109 renderer_->SetDelegate(delegate_.GetWeakPtr());
110 } 110 }
111 111
112 void GlRendererTest::RequestRender() { 112 void GlRendererTest::RequestRender() {
113 renderer_->RequestRender(); 113 renderer_->RequestRender();
114 } 114 }
115 115
116 void GlRendererTest::SetDesktopFrameWithSize(const webrtc::DesktopSize& size) { 116 void GlRendererTest::SetDesktopFrameWithSize(const webrtc::DesktopSize& size) {
117 renderer_->OnFrameReceived( 117 renderer_->OnFrameReceived(
118 base::WrapUnique( 118 base::MakeUnique<webrtc::BasicDesktopFrame>(size),
119 new webrtc::BasicDesktopFrame(size)),
120 base::Bind(&GlRendererTest::OnDesktopFrameProcessed, 119 base::Bind(&GlRendererTest::OnDesktopFrameProcessed,
121 base::Unretained(this))); 120 base::Unretained(this)));
122 } 121 }
123 122
124 void GlRendererTest::PostSetDesktopFrameTasks( 123 void GlRendererTest::PostSetDesktopFrameTasks(
125 const webrtc::DesktopSize& size, int count) { 124 const webrtc::DesktopSize& size, int count) {
126 for (int i = 0; i < count; i++) { 125 for (int i = 0; i < count; i++) {
127 message_loop_.task_runner()->PostTask( 126 message_loop_.task_runner()->PostTask(
128 FROM_HERE, base::Bind(&GlRendererTest::SetDesktopFrameWithSize, 127 FROM_HERE, base::Bind(&GlRendererTest::SetDesktopFrameWithSize,
129 base::Unretained(this), size)); 128 base::Unretained(this), size));
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 210
212 PostSetDesktopFrameTasks(webrtc::DesktopSize(16, 16), 20); 211 PostSetDesktopFrameTasks(webrtc::DesktopSize(16, 16), 20);
213 RunUntilRendered(); 212 RunUntilRendered();
214 EXPECT_EQ(2, delegate_.on_frame_rendered_call_count()); 213 EXPECT_EQ(2, delegate_.on_frame_rendered_call_count());
215 EXPECT_EQ(21, on_desktop_frame_processed_call_count()); 214 EXPECT_EQ(21, on_desktop_frame_processed_call_count());
216 } 215 }
217 216
218 // TODO(yuweih): Add tests to validate the rendered output. 217 // TODO(yuweih): Add tests to validate the rendered output.
219 218
220 } // namespace remoting 219 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/client/gl_desktop.cc ('k') | remoting/client/jni/chromoting_jni_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698