Don't mark navigations as in-page when DSNs are mismatched.

Don't mark navigations as in-page when DSNs are mismatched.

This CL implements a TODO by creis@ to ensure that the renderer doesn't
classify history navigations as in-page if the document sequence number
of the current document and the one being navigated to are mismatched.

BUG=628677, 630103
Committed: https://crrev.com/cf477b509f7a5a3409ac1f2aecf9513d7c82c5b3
Cr-Commit-Position: refs/heads/master@{#413353}

[nasko, 2016-08-17 20:05:20]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 20:05:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:03:24]

Dry run: This issue passed the CQ dry run.

[nasko, 2016-08-17 21:04:56]

nasko@chromium.org changed reviewers:
+ avi@chromium.org

[nasko, 2016-08-17 21:04:56]

Hey Avi,
Can you review this CL for me? I will not land it immediately, but since you
will be out for the rest of the week, it will be good to have it reviewed.
I plan on landing it on Friday and see if it helps with the origin/URL mismatch
issues.
Thanks in advance!
Nasko

[Avi (use Gerrit), 2016-08-17 21:06:40]

LGTM; land when you are satisfied this is the right thing to do.

[nasko, 2016-08-20 18:31:22]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-08-20 18:31:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 19:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 19:12:15]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nasko, 2016-08-20 19:50:52]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-08-20 19:51:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 20:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 20:29:22]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nasko, 2016-08-20 23:25:23]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-08-20 23:25:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 23:55:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-20 23:57:14]

Description was changed from

==========
Don't mark navigations as in-page when DSNs are mismatched.

This CL implements a TODO by creis@ to ensure that the renderer doesn't
classify history navigations as in-page if the document sequence number
of the current document and the one being navigated to are mismatched.

BUG=628677, 630103
==========

to

==========
Don't mark navigations as in-page when DSNs are mismatched.

This CL implements a TODO by creis@ to ensure that the renderer doesn't
classify history navigations as in-page if the document sequence number
of the current document and the one being navigated to are mismatched.

BUG=628677, 630103

Committed: https://crrev.com/cf477b509f7a5a3409ac1f2aecf9513d7c82c5b3
Cr-Commit-Position: refs/heads/master@{#413353}
==========

[commit-bot: I haz the power, 2016-08-20 23:57:15]

Patchset 1 (id:??) landed as
https://crrev.com/cf477b509f7a5a3409ac1f2aecf9513d7c82c5b3
Cr-Commit-Position: refs/heads/master@{#413353}

[Charlie Reis, 2016-08-22 12:20:20]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2016-08-22 12:20:21]

Thanks for adding this!  I'm curious if it helps.

One concern about the NOTREACHED below, which we should probably fix in a
followup CL.

https://codereview.chromium.org/2253233002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2253233002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:5541: NOTREACHED();
I don't think we can have a NOTREACHED in this case, due to races where the
renderer process navigates to a different document (e.g., synchronous commit to
about:blank) just as the browser is telling it to go back in-page.  I bet we
could even write a test for that case.  :)

My TODO to add a NOTREACHED was for the "no current history item" case, when the
browser should know better than to treat it as in-page.  We should still do
that.

[nasko, 2016-08-28 02:18:27]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2287933002/ by nasko@chromium.org.

The reason for reverting is: Reverting post branch point for another attempt at
diagnosing the remaining cases where origin and URL are mismatched..