Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Issue 2253223002: bluetooth: Implement hardware filtering on macOS (Closed)

Created:
4 years, 4 months ago by ortuno
Modified:
4 years, 3 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Implement hardware filtering on macOS Passes the UUIDs in the filters to mac's function to scan for device. This allows for a more efficient scan of devices. BUG=638704

Patch Set 1 #

Patch Set 2 : Format #

Patch Set 3 : Fix #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -34 lines) Patch
M device/bluetooth/bluetooth_adapter_mac.mm View 1 5 chunks +21 lines, -13 lines 3 comments Download
M device/bluetooth/bluetooth_adapter_mac_unittest.mm View 1 2 5 chunks +184 lines, -8 lines 3 comments Download
M device/bluetooth/bluetooth_low_energy_discovery_manager_mac.h View 1 2 chunks +9 lines, -3 lines 2 comments Download
M device/bluetooth/bluetooth_low_energy_discovery_manager_mac.mm View 1 3 chunks +45 lines, -9 lines 3 comments Download
M device/bluetooth/test/mock_bluetooth_central_manager_mac.h View 3 chunks +8 lines, -1 line 0 comments Download
M device/bluetooth/test/mock_bluetooth_central_manager_mac.mm View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
ortuno
jyasskin: PTAL
4 years, 4 months ago (2016-08-23 02:59:44 UTC) #10
Jeffrey Yasskin
https://codereview.chromium.org/2253223002/diff/40001/device/bluetooth/bluetooth_adapter_mac.mm File device/bluetooth/bluetooth_adapter_mac.mm (right): https://codereview.chromium.org/2253223002/diff/40001/device/bluetooth/bluetooth_adapter_mac.mm#newcode300 device/bluetooth/bluetooth_adapter_mac.mm:300: BluetoothDiscoveryFilter* discovery_filter, If we're guaranteed this is never null, ...
4 years, 4 months ago (2016-08-23 21:37:04 UTC) #11
ortuno
4 years, 3 months ago (2016-08-25 17:58:31 UTC) #12
Message was sent while issue was closed.
I'm closing this for now. I realized that more refactoring is needed and
whatever refactor we do with mac will be eventually replaced by the cross
platform implementation.

https://codereview.chromium.org/2253223002/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_mac.mm (right):

https://codereview.chromium.org/2253223002/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_mac.mm:300: BluetoothDiscoveryFilter*
discovery_filter,
On 2016/08/23 at 21:37:04, Jeffrey Yasskin wrote:
> If we're guaranteed this is never null, can this become a const
BluetoothDiscoveryFilter& for all adapters?

Ah my bad. BluetoothDiscoveryFilter is not guaranteed to be there because of
StartDiscoverySession. (Which just calls
StartDiscoverySessionWithFilter(nullptr...).)

Powered by Google App Engine
This is Rietveld 408576698