Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2253203002: Misc cleanup. (Closed)

Created:
4 years, 4 months ago by Bence
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Misc cleanup. This CL is a collection of changes that are too small for individual CLs. * Mark two HttpStreamFactoryImpl::Job members const, since they are never changed. * Remove unused CryptoConfigMap typedef. * Make SpdyNetworkTransactionTest::NormalSpdyTransactionHelper::output() method return const ref instead of unconventional non-const ref. * Remove unused SpdyNetworkTransactionTest::NormalSpdyTransactionHelper members. * In two SpdyNetworkTransactionTests, use NormalSpdyTransactionHelper methods to start transaction and wait for callback instead of directly manipulating helper.trans(). Committed: https://crrev.com/4d782f4935e5a1b3c19d6ee3725928bcc7f2e936 Cr-Commit-Position: refs/heads/master@{#412817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -34 lines) Patch
M net/http/http_stream_factory_impl_job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 5 chunks +21 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 4 months ago (2016-08-18 12:16:05 UTC) #6
Ryan Hamilton
lgtm
4 years, 4 months ago (2016-08-18 13:45:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253203002/1
4 years, 4 months ago (2016-08-18 13:45:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 13:50:18 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 13:53:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d782f4935e5a1b3c19d6ee3725928bcc7f2e936
Cr-Commit-Position: refs/heads/master@{#412817}

Powered by Google App Engine
This is Rietveld 408576698