Chromium Code Reviews| Index: chrome/browser/chromeos/system_logs/about_system_logs_fetcher.cc |
| diff --git a/chrome/browser/chromeos/system_logs/system_logs_fetcher.cc b/chrome/browser/chromeos/system_logs/about_system_logs_fetcher.cc |
| similarity index 51% |
| copy from chrome/browser/chromeos/system_logs/system_logs_fetcher.cc |
| copy to chrome/browser/chromeos/system_logs/about_system_logs_fetcher.cc |
| index e34c06dd11cf4fccffc73bc24cccd26c4f20e28a..f553f9bc0affe3d85a618d2f5a2083ef84478fba 100644 |
| --- a/chrome/browser/chromeos/system_logs/system_logs_fetcher.cc |
| +++ b/chrome/browser/chromeos/system_logs/about_system_logs_fetcher.cc |
| @@ -2,7 +2,7 @@ |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| -#include "chrome/browser/chromeos/system_logs/system_logs_fetcher.h" |
| +#include "chrome/browser/chromeos/system_logs/about_system_logs_fetcher.h" |
| #include "base/bind.h" |
| #include "base/bind_helpers.h" |
| @@ -20,12 +20,9 @@ using content::BrowserThread; |
| namespace chromeos { |
| -SystemLogsFetcher::SystemLogsFetcher() |
| - : response_(new SystemLogsResponse), |
| - num_pending_requests_(0), |
| - weak_ptr_factory_(this) { |
| +AboutSystemLogsFetcher::AboutSystemLogsFetcher() { |
| // Debug Daemon data source. |
| - data_sources_.push_back(new DebugDaemonLogSource()); |
| + data_sources_.push_back(new DebugDaemonLogSource(false)); |
| // Chrome data sources. |
| data_sources_.push_back(new ChromeInternalLogSource()); |
| @@ -39,37 +36,10 @@ SystemLogsFetcher::SystemLogsFetcher() |
| num_pending_requests_ = data_sources_.size(); |
| } |
| -SystemLogsFetcher::~SystemLogsFetcher() {} |
| +AboutSystemLogsFetcher::~AboutSystemLogsFetcher() {} |
|
stevenjb
2013/08/09 02:18:51
nit: } on separate line when not inline
rkc
2013/08/09 18:24:18
Done.
|
| -void SystemLogsFetcher::Fetch(const SysLogsFetcherCallback& callback) { |
| - DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
| - DCHECK(callback_.is_null()); |
| - DCHECK(!callback.is_null()); |
| - |
| - callback_ = callback; |
| - for (size_t i = 0; i < data_sources_.size(); ++i) { |
| - data_sources_[i]->Fetch(base::Bind(&SystemLogsFetcher::AddResponse, |
| - weak_ptr_factory_.GetWeakPtr())); |
| - } |
| -} |
| - |
| -void SystemLogsFetcher::AddResponse(SystemLogsResponse* response) { |
| - DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
| - |
| - for (SystemLogsResponse::const_iterator it = response->begin(); |
| - it != response->end(); |
| - ++it) { |
| - // It is an error to insert an element with a pre-existing key. |
| - bool ok = response_->insert(*it).second; |
| - DCHECK(ok) << "Duplicate key found: " << it->first; |
| - } |
| - |
| - --num_pending_requests_; |
| - if (num_pending_requests_ > 0) |
| - return; |
| - |
| - callback_.Run(response_.Pass()); |
| - BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, this); |
| +base::WeakPtr<SystemLogsFetcherBase> AboutSystemLogsFetcher::GetWeakPtr() { |
| + return AsWeakPtr(); |
| } |
| } // namespace chromeos |