Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 2253153002: Add --bazel-paths option to dart2js entrypoint. (Closed)

Created:
4 years, 4 months ago by Harry Terkelsen
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add --bazel-paths option to dart2js entrypoint. This allows us to resolve files by looking them up in multiple bazel roots, which allows us to avoid creating a massive symlink farm. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b7a0a42bf6fc4576fc070c5132af4194a312d983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -35 lines) Patch
M pkg/compiler/lib/src/commandline_options.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 11 chunks +68 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 4 months ago (2016-08-17 17:47:17 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 4 months ago (2016-08-17 17:58:04 UTC) #3
Harry Terkelsen
4 years, 4 months ago (2016-08-17 18:00:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7a0a42bf6fc4576fc070c5132af4194a312d983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698