src/ia32/lithium-ia32.cc - Issue 225313003: Reland "Fixed environment assignment for LCheckNonSmi."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-ia32.cc

Issue 225313003: Reland "Fixed environment assignment for LCheckNonSmi." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-ia32.cc

diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc

index 66c79d1d587c2cf1857789728993c87e2cc97f43..cb15e0d82f4872f7b3bbc1608cf5d49c90126f22 100644

--- a/src/ia32/lithium-ia32.cc

+++ b/src/ia32/lithium-ia32.cc

@@ -2007,7 +2007,9 @@ LInstruction* LChunkBuilder::DoChange(HChange* instr) {

LInstruction* LChunkBuilder::DoCheckHeapObject(HCheckHeapObject* instr) {

LOperand* value = UseAtStart(instr->value());

- return AssignEnvironment(new(zone()) LCheckNonSmi(value));

+ LInstruction* result = new(zone()) LCheckNonSmi(value);

+ if (!instr->value()->IsHeapObject()) result = AssignEnvironment(result);

+ return result;

}

« no previous file with comments | « src/arm64/lithium-arm64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »