Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: src/arm64/lithium-arm64.cc

Issue 225313003: Reland "Fixed environment assignment for LCheckNonSmi." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1184 matching lines...) Expand 10 before | Expand all | Expand 10 after
1195 if (!instr->CanOmitMapChecks()) { 1195 if (!instr->CanOmitMapChecks()) {
1196 result = AssignEnvironment(result); 1196 result = AssignEnvironment(result);
1197 if (instr->has_migration_target()) result = AssignPointerMap(result); 1197 if (instr->has_migration_target()) result = AssignPointerMap(result);
1198 } 1198 }
1199 return result; 1199 return result;
1200 } 1200 }
1201 1201
1202 1202
1203 LInstruction* LChunkBuilder::DoCheckHeapObject(HCheckHeapObject* instr) { 1203 LInstruction* LChunkBuilder::DoCheckHeapObject(HCheckHeapObject* instr) {
1204 LOperand* value = UseRegisterAtStart(instr->value()); 1204 LOperand* value = UseRegisterAtStart(instr->value());
1205 return AssignEnvironment(new(zone()) LCheckNonSmi(value)); 1205 LInstruction* result = new(zone()) LCheckNonSmi(value);
1206 if (!instr->value()->IsHeapObject()) result = AssignEnvironment(result);
1207 return result;
1206 } 1208 }
1207 1209
1208 1210
1209 LInstruction* LChunkBuilder::DoCheckSmi(HCheckSmi* instr) { 1211 LInstruction* LChunkBuilder::DoCheckSmi(HCheckSmi* instr) {
1210 LOperand* value = UseRegisterAtStart(instr->value()); 1212 LOperand* value = UseRegisterAtStart(instr->value());
1211 return AssignEnvironment(new(zone()) LCheckSmi(value)); 1213 return AssignEnvironment(new(zone()) LCheckSmi(value));
1212 } 1214 }
1213 1215
1214 1216
1215 LInstruction* LChunkBuilder::DoClampToUint8(HClampToUint8* instr) { 1217 LInstruction* LChunkBuilder::DoClampToUint8(HClampToUint8* instr) {
(...skipping 1345 matching lines...) Expand 10 before | Expand all | Expand 10 after
2561 2563
2562 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) { 2564 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) {
2563 LOperand* receiver = UseRegister(instr->receiver()); 2565 LOperand* receiver = UseRegister(instr->receiver());
2564 LOperand* function = UseRegister(instr->function()); 2566 LOperand* function = UseRegister(instr->function());
2565 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function); 2567 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function);
2566 return AssignEnvironment(DefineAsRegister(result)); 2568 return AssignEnvironment(DefineAsRegister(result));
2567 } 2569 }
2568 2570
2569 2571
2570 } } // namespace v8::internal 2572 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698