Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/ui/commands/show_signin_command.mm

Issue 2253113002: Add signin_metrics::AccessPoint to ShowSigninCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/commands/show_signin_command.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/commands/show_signin_command.mm
diff --git a/ios/chrome/browser/ui/commands/show_signin_command.mm b/ios/chrome/browser/ui/commands/show_signin_command.mm
index add4797dfea8bde68e6e1e4389cbe687f10d3adc..ca152fe368ef849ef93a563bbb0bca4b405d9e95 100644
--- a/ios/chrome/browser/ui/commands/show_signin_command.mm
+++ b/ios/chrome/browser/ui/commands/show_signin_command.mm
@@ -14,6 +14,7 @@
@synthesize operation = _operation;
@synthesize signInSource = _signInSource;
+@synthesize signInAccessPoint = _signInAccessPoint;
- (instancetype)initWithTag:(NSInteger)tag {
NOTREACHED();
@@ -38,6 +39,26 @@
[self initWithOperation:operation signInSource:signInSource callback:nil];
}
+- (instancetype)initWithOperation:(AuthenticationOperation)operation
+ signInAccessPoint:(signin_metrics::AccessPoint)signInAccessPoint
+ callback:
+ (ShowSigninCommandCompletionCallback)callback {
+ if ((self = [self initWithOperation:operation
+ signInSource:SIGN_IN_SOURCE_OTHER
+ callback:callback])) {
+ _signInAccessPoint = signInAccessPoint;
+ }
+ return self;
+}
+
+- (instancetype)initWithOperation:(AuthenticationOperation)operation
+ signInAccessPoint:
+ (signin_metrics::AccessPoint)signInAccessPoint {
+ return [self initWithOperation:operation
+ signInAccessPoint:signInAccessPoint
+ callback:nil];
+}
+
- (ShowSigninCommandCompletionCallback)callback {
return _callback.get();
}
« no previous file with comments | « ios/chrome/browser/ui/commands/show_signin_command.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698