Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: ios/chrome/browser/ui/commands/show_signin_command.h

Issue 2253113002: Add signin_metrics::AccessPoint to ShowSigninCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/commands/show_signin_command.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/commands/show_signin_command.h
diff --git a/ios/chrome/browser/ui/commands/show_signin_command.h b/ios/chrome/browser/ui/commands/show_signin_command.h
index 7f538fdca69460e8a4ff6e7cd7bcc6ee7c57dea6..efc415980e056760392eacf5762531af47ab07c9 100644
--- a/ios/chrome/browser/ui/commands/show_signin_command.h
+++ b/ios/chrome/browser/ui/commands/show_signin_command.h
@@ -7,6 +7,7 @@
#import <Foundation/Foundation.h>
+#include "components/signin/core/browser/signin_metrics.h"
#include "ios/chrome/browser/signin/constants.h"
#include "ios/chrome/browser/ui/commands/generic_chrome_command.h"
@@ -43,6 +44,17 @@ enum AuthenticationOperation {
- (instancetype)initWithOperation:(AuthenticationOperation)operation
signInSource:(SignInSource)signInSource;
+// Initializes a command to perform the specified operation with a
+// SigninInteractionController and invoke a possibly-nil callback when finished.
+- (instancetype)initWithOperation:(AuthenticationOperation)operation
+ signInAccessPoint:(signin_metrics::AccessPoint)signInAccessPoint
+ callback:(ShowSigninCommandCompletionCallback)callback;
+
+// Initializes a ShowSigninCommand with a nil callback.
+- (instancetype)initWithOperation:(AuthenticationOperation)operation
+ signInAccessPoint:
+ (signin_metrics::AccessPoint)signInAccessPoint;
+
// The callback to be invoked after the operation is complete.
@property(nonatomic, readonly) ShowSigninCommandCompletionCallback callback;
@@ -52,6 +64,9 @@ enum AuthenticationOperation {
// The source of this authentication operation.
@property(nonatomic, readonly) SignInSource signInSource;
+// The access point of this authentication operation.
+@property(nonatomic, readonly) signin_metrics::AccessPoint signInAccessPoint;
+
@end
#endif // IOS_CHROME_BROWSER_UI_COMMANDS_SHOW_SIGNIN_COMMAND_H_
« no previous file with comments | « no previous file | ios/chrome/browser/ui/commands/show_signin_command.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698