Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2253093002: Always inherit language-mode from the outer scope, modules initialize language-mode later (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Always inherit language-mode from the outer scope, modules initialize language-mode later BUG=v8:5209 Committed: https://crrev.com/1c6cb5a40a9d337e44f87393f3e63b985d29c388 Cr-Commit-Position: refs/heads/master@{#38685}

Patch Set 1 #

Patch Set 2 : Actually inherit the language mode :) #

Total comments: 1

Patch Set 3 : Nuke comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/ast/scopes.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-17 15:15:20 UTC) #2
neis
lgtm https://codereview.chromium.org/2253093002/diff/20001/src/ast/scopes.cc File src/ast/scopes.cc (right): https://codereview.chromium.org/2253093002/diff/20001/src/ast/scopes.cc#newcode92 src/ast/scopes.cc:92: // Inherit the language mode from the parent ...
4 years, 4 months ago (2016-08-17 15:22:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253093002/40001
4 years, 4 months ago (2016-08-17 15:24:53 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-17 15:54:08 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 15:54:35 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1c6cb5a40a9d337e44f87393f3e63b985d29c388
Cr-Commit-Position: refs/heads/master@{#38685}

Powered by Google App Engine
This is Rietveld 408576698